From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
To: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: msys2 vs pg_upgrade/test.sh
Date: Mon, 9 Sep 2019 10:48:55 +0200
Message-ID: <4a76b98b-4a00-7df2-8912-9363277b604f@2ndquadrant.com> (raw)
In-Reply-To: <3227042f-cfcc-745a-57dd-fb8c471f8ddf@2ndQuadrant.com>
References: <3227042f-cfcc-745a-57dd-fb8c471f8ddf@2ndQuadrant.com>
On 2019-09-09 00:06, Andrew Dunstan wrote:
> Diagnosing this took quite a lot of time and detective work. For some
> reason I don't quite understand, when calling the Windows command
> processor in a modern msys2/WindowsServer2019 installation, you need to
> double the slash, thus:
>
> cmd //c foo.bat
>
> Some Internet postings at least seem to suggest this is by design. (FSVO
> "design")
>
> I tested this on older versions and the change appears to work, so I
> propose to apply the attached patch.
If we're worried about messing things up for non-msys2 environments, we
could also set MSYS2_ARG_CONV_EXCL instead; see
<https://github.com/msys2/msys2/wiki/Porting#filesystem-namespaces;.
According to that page, that would seem to be the more proper way to do it.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: peter.eisentraut@2ndquadrant.com, andrew.dunstan@2ndquadrant.com
Subject: Re: msys2 vs pg_upgrade/test.sh
In-Reply-To: <4a76b98b-4a00-7df2-8912-9363277b604f@2ndquadrant.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox