From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Andrey Klychkov <aaklychkov@mail.ru>
Cc: Victor Yegorov <vyegorov@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Alter index rename concurrently to
Date: Wed, 1 Aug 2018 09:04:20 +0200
Message-ID: <4aadd527-9986-36bd-978c-2300a95e7aec@2ndquadrant.com> (raw)
In-Reply-To: <10678.1533072318@sss.pgh.pa.us>
References: <1531767486.432607658@f357.i.mail.ru>
<CAGnEboiyFkmGbQFAvc+tViayyPnbJkWTd93kvmhhML+cQQ_OkA@mail.gmail.com>
<1531828116.497549417@f411.i.mail.ru>
<6cf6b35f-b730-60fc-bab7-82699dca59ed@2ndquadrant.com>
<CA+TgmobtmFT5g-0dA=vEFFtogjRAuDHcYPw+qEdou5dZPnF=pg@mail.gmail.com>
<c3d9a44c-2ca1-6726-ad03-ed9c37cc7c29@2ndquadrant.com>
<10678.1533072318@sss.pgh.pa.us>
On 31/07/2018 23:25, Tom Lane wrote:
> Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
>> On 27/07/2018 16:16, Robert Haas wrote:
>>> I also suspect that an appropriate fix might be to ensure that
>>> AcceptInvalidationMessages() is run at least once at the beginning of
>>> parse analysis.
>
>> Why don't we just do that?
>
> Don't we do that already? Certainly it should get run in advance of
> any relation name lookup. There is one at transaction start also,
> if memory serves.
Right, we do it at transaction start and when opening a relation with a
lock that you don't already have. Which I suppose in practice is almost
equivalent to at least once per command, but you can construct cases
where subsequent commands in a transaction use the all same tables as
the previous commands, in which case they don't run AIM() again.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: peter.eisentraut@2ndquadrant.com, tgl@sss.pgh.pa.us, robertmhaas@gmail.com, aaklychkov@mail.ru, vyegorov@gmail.com
Subject: Re: Alter index rename concurrently to
In-Reply-To: <4aadd527-9986-36bd-978c-2300a95e7aec@2ndquadrant.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox