pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Jeff Davis <pgsql@j-davis.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: pgsql-hackers@postgresql.org
Subject: Re: Is this a problem in GenericXLogFinish()?
Date: Fri, 20 Oct 2023 09:28:17 -0700
Message-ID: <4b2dfe9c67713413a06be761f677bc34222afcb4.camel@j-davis.com> (raw)
In-Reply-To: <CA+TgmoY+dagCyrMKau7UQeQU6w4LuVEu+yjsmJBoXKAo6XbUUA@mail.gmail.com>
References: <d2c31606e6bb9b83a02ed4835d65191b38d4ba12.camel@j-davis.com>
	<25104133-7df8-cae3-b9a2-1c0aaa1c094a@iki.fi>
	<399492009193fa2c37a61b630e4449546a550039.camel@j-davis.com>
	<c84114f8-c7f1-5b57-f85a-3adc31e1a904@iki.fi>
	<146426fc662f88604c700a72a3833b1919922f9e.camel@j-davis.com>
	<CA+TgmobvdZMWj5=fextXP_Q81eS9g0sbVbVE4qiKAtJs8dMjyA@mail.gmail.com>
	<08b4f1f7dcf321d38373f06acc65a8d62cc2f017.camel@j-davis.com>
	<CA+TgmoZ24f5eNNJFV6chv+xjCOOy9-uZqwPwrWVvQMZfHUsMxQ@mail.gmail.com>
	<6d23aff2-7151-65b1-528b-2189ffa6e2df@iki.fi>
	<57c59f08bbb92875251dc97dbc47600fa237712c.camel@j-davis.com>
	<50bebdf8bbf79475e3fc0fff398d77b1577c1b97.camel@j-davis.com>
	<bf396b45-318a-4940-87eb-3d295a93da8b@iki.fi>
	<b1f2d0f230d60fa8df33bb0b2af3236fde9d750d.camel@j-davis.com>
	<CA+TgmoZ54E0w5vCXYRAFKnunZy_SKB-4rbFq+7L=qUgFUYdtfQ@mail.gmail.com>
	<d54c5738052eead54d65e4fd3667f161aa447680.camel@j-davis.com>
	<CA+TgmoY+dagCyrMKau7UQeQU6w4LuVEu+yjsmJBoXKAo6XbUUA@mail.gmail.com>

On Thu, 2023-10-19 at 16:12 -0400, Robert Haas wrote:
> For what it's worth, though, I think it would be better to
> just make these cases exceptions to your Assert

OK, I'll probably commit something like v4 then.

I still have a question though: if a buffer is exclusive-locked,
unmodified and clean, and then the caller registers it and later does
PageSetLSN (just as if it were dirty), is that a definite bug?

There are a couple callsites where the control flow is complex enough
that it's hard to be sure the buffer is always marked dirty before
being registered (like in log_heap_visible(), as I mentioned upthread).
But those callsites are all doing PageSetLSN, unlike the hash index
case.

Regards,
	Jeff Davis






view thread (64+ messages)  latest in thread

Message-ID: <4b2dfe9c67713413a06be761f677bc34222afcb4.camel@j-davis.com>
Permalink:  ../4b2dfe9c67713413a06be761f677bc34222afcb4.camel@j-davis.com/
Also on:    postgresql.org/message-id/4b2dfe9c67713413a06be761f677bc34222afcb4.camel@j-davis.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: pgsql@j-davis.com, robertmhaas@gmail.com, hlinnaka@iki.fi
  Subject: Re: Is this a problem in GenericXLogFinish()?
  In-Reply-To: <4b2dfe9c67713413a06be761f677bc34222afcb4.camel@j-davis.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox