pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Thomas Munro <thomas.munro@enterprisedb.com>
To: Christoph Berg <myon@debian.org>
To: Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Collation versioning
Date: Wed, 2 Oct 2019 20:52:31 +0200
Message-ID: <4b76c6d4-ae5e-0dc6-7d0d-b5c796a07e34@2ndquadrant.com> (raw)
In-Reply-To: <CAEepm=3mKYhXS9NQCsPkGhkQxKAeZwbDneZV7QYKTDDYstTxZA@mail.gmail.com>
References: <CAEepm=0hoACQLFn8ro7jCO9-wTth2mXXS3K=s09gxKqN2jy8pA@mail.gmail.com>
	<CAEepm=3a5BC7CwsXZo3V4fw6YuAMT2nJ1krwtqOatb=vDqRWEA@mail.gmail.com>
	<20180905191014.GA29241@msg.df7cb.de>
	<CAEepm=3mKYhXS9NQCsPkGhkQxKAeZwbDneZV7QYKTDDYstTxZA@mail.gmail.com>

On 2018-09-05 23:18, Thomas Munro wrote:
> On Wed, Sep 5, 2018 at 12:10 PM Christoph Berg <myon@debian.org> wrote:
>>> So, it's not ideal but perhaps worth considering on the grounds that
>>> it's better than nothing?
>>
>> Ack.
> 
> Ok, here's a little patch like that.
> 
> postgres=# select collname, collcollate, collversion from pg_collation
> where collname = 'en_NZ';
>  collname | collcollate | collversion
> ----------+-------------+-------------
>  en_NZ    | en_NZ.utf8  | 2.24
> (1 row)

After, um, briefly sleeping on this, I would like to go ahead with this.

There is ongoing work to make ICU available globally, and as part of
that I've also proposed a way to make the collation version tracking
work on a database level.

This here would be a useful piece on the overall picture.  Independent
of what becomes of the ICU effort, we could have glibc collation version
tracking completely working for PG13.

The only open question on this patch was whether it's a good version to
use.  I think based on subsequent discussions, there was the realization
that this is the best we can do and better than nothing.

In the patch, I would skip the configure test and just do

#ifdef __GLIBC__

directly.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services





view thread (188+ messages)  latest in thread

Message-ID: <4b76c6d4-ae5e-0dc6-7d0d-b5c796a07e34@2ndquadrant.com>
Permalink:  ../4b76c6d4-ae5e-0dc6-7d0d-b5c796a07e34@2ndquadrant.com/
Also on:    postgresql.org/message-id/4b76c6d4-ae5e-0dc6-7d0d-b5c796a07e34@2ndquadrant.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: peter.eisentraut@2ndquadrant.com, thomas.munro@enterprisedb.com, myon@debian.org
  Subject: Re: Collation versioning
  In-Reply-To: <4b76c6d4-ae5e-0dc6-7d0d-b5c796a07e34@2ndquadrant.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox