public inbox for [email protected]  
help / color / mirror / Atom feed
From: Vik Fearing <[email protected]>
To: Surafel Temesgen <[email protected]>
To: Ibrar Ahmed <[email protected]>
Cc: Simon Riggs <[email protected]>
Cc: RĂ©mi Lapeyre <[email protected]>
Cc: Ryan Lambert <[email protected]>
Cc: Masahiko Sawada <[email protected]>
Cc: Michael Paquier <[email protected]>
Cc: Eli Marmor <[email protected]>
Cc: David Steele <[email protected]>
Cc: PostgreSQL-development <[email protected]>
Cc: Georgios <[email protected]>
Cc: Li Japin <[email protected]>
Subject: Re: WIP: System Versioned Temporal Table
Date: Wed, 10 Mar 2021 18:02:53 +0100
Message-ID: <[email protected]> (raw)
In-Reply-To: <CALAY4q-DwwXUDNgSA3uUxGNzCdWab87re_+dS55UkmzPYmCUqQ@mail.gmail.com>
References: <[email protected]>
	<CANbhV-EOTSc2EWS_LKiXKgLqnrjtaU0hf3Rzxn111nir6Pn4zA@mail.gmail.com>
	<CANbhV-ECkPhsXEtj7gYFjXCdq+3WTiHo9XkF5wQmFOj4w+YTaw@mail.gmail.com>
	<CANbhV-Fb35HMoySGMFfcxN_3i45Bb6cZODOcz8S7+Nys3Y2raA@mail.gmail.com>
	<CAN-V+g-D7bObC3m5rcm3zr8MmTVE4_OVJuEp8Qse0ZgE4PAhsw@mail.gmail.com>
	<CANbhV-F3S=5+5w19cowPwewBXSV3+C5T3BD327KQD7BLFgZbCQ@mail.gmail.com>
	<CAN-V+g_7EC=kAVeQV=+XL+KoV=QLdx_79J55OBarEYd49_uHRA@mail.gmail.com>
	<CANbhV-H-Wt7TVEwzzaYNEZ8-OteipdtvsxN1Qr1G9XpZoX2GgA@mail.gmail.com>
	<CANbhV-EymXWOFdX-Sz7PqQ8kphqHMteErBgD=FxmE+uF7jVW4w@mail.gmail.com>
	<[email protected]>
	<CALAY4q-4YpPc=hSGpxCJBVwpTKzm2A5JyoXUr+2Lh0KTiUcjPQ@mail.gmail.com>
	<[email protected]>
	<CALtqXTeMemTWNUQfa9_M+p=eOcvw5yLyfRReBu2BrAbo8rkYNw@mail.gmail.com>
	<CALAY4q-DwwXUDNgSA3uUxGNzCdWab87re_+dS55UkmzPYmCUqQ@mail.gmail.com>

On 3/10/21 5:49 PM, Surafel Temesgen wrote:
> hi Ibrar,
> thank you for rebasing
> 
> On Mon, Mar 8, 2021 at 9:34 AM Ibrar Ahmed <[email protected]> wrote:
> 
>>
>>> Since the get_row_start_time_col_name() and get_row_end_time_col_name()
>>> are similar, IMO we can pass a flag to get StartTime/EndTime column name,
>>> thought?
>>>
>>>
> For me your option is better.  i will change to it in my next
> patch if no objection

I have plenty of objection.  I'm sorry that I am taking so long with my
review.  I am still working on it and it is coming soon, I promise.
-- 
Vik Fearing





view thread (97+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: WIP: System Versioned Temporal Table
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox