pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Andrey V. Lepikhov <a.lepikhov@postgrespro.ru>
To: Etsuro Fujita <etsuro.fujita@gmail.com>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Cc: movead.li <movead.li@highgo.ca>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Asynchronous Append on postgres_fdw nodes.
Date: Thu, 10 Dec 2020 11:38:04 +0500
Message-ID: <4bdaf2f5-00b9-7e62-349d-ea3dbff7c36b@postgrespro.ru> (raw)
In-Reply-To: <CAPmGK14xrGe+Xks7+fVLBoUUbKwcDkT9km1oFXhdY+FFhbMjUg@mail.gmail.com>
References: <CAPmGK153oorYtTpW_-aZrjH-iecHbykX7qbxX_5630ZK8nqVHg@mail.gmail.com>
	<20201002.153925.2111528346612886434.horikyota.ntt@gmail.com>
	<CAPmGK16YXCADSwsFLSxqTBBLbt3E_=iigKTtjS=dqu+8K8DWCw@mail.gmail.com>
	<20201005.132959.1424481454550541470.horikyota.ntt@gmail.com>
	<CAPmGK17Ura3NUXYP98W4jz0VT9BAyVFhNRqZyFV-_mqFDB0j7Q@mail.gmail.com>
	<CAPmGK14xrGe+Xks7+fVLBoUUbKwcDkT9km1oFXhdY+FFhbMjUg@mail.gmail.com>

On 11/17/20 2:56 PM, Etsuro Fujita wrote:
> On Mon, Oct 5, 2020 at 3:35 PM Etsuro Fujita <etsuro.fujita@gmail.com> wrote:
> Comments welcome!  The attached is still WIP and maybe I'm missing
> something, though.
I reviewed your patch and used it in my TPC-H benchmarks. It is still 
WIP. Will you improve this patch?

I also want to say that, in my opinion, Horiguchi-san's version seems 
preferable: it is more structured, simple to understand, executor-native 
and allows to reduce FDW interface changes. This code really only needs 
one procedure - IsForeignPathAsyncCapable.

-- 
regards,
Andrey Lepikhov
Postgres Professional





view thread (130+ messages)  latest in thread

Message-ID: <4bdaf2f5-00b9-7e62-349d-ea3dbff7c36b@postgrespro.ru>
Permalink:  ../4bdaf2f5-00b9-7e62-349d-ea3dbff7c36b@postgrespro.ru/
Also on:    postgresql.org/message-id/4bdaf2f5-00b9-7e62-349d-ea3dbff7c36b@postgrespro.ru

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: a.lepikhov@postgrespro.ru, etsuro.fujita@gmail.com, horikyota.ntt@gmail.com, pryzby@telsasoft.com, movead.li@highgo.ca, pgsql-hackers@lists.postgresql.org
  Subject: Re: Asynchronous Append on postgres_fdw nodes.
  In-Reply-To: <4bdaf2f5-00b9-7e62-349d-ea3dbff7c36b@postgrespro.ru>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox