From: Teodor Sigaev <teodor@sigaev.ru>
To: Peter Geoghegan <pg@bowt.ie>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Alexander Korotkov <a.korotkov@postgrespro.ru>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
Cc: Jaime Casanova <jaime.casanova@2ndquadrant.com>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Partitioned tables and covering indexes
Date: Thu, 12 Apr 2018 16:47:52 +0300
Message-ID: <4cfeb27e-e777-94f3-11eb-71fd070d3205@sigaev.ru> (raw)
In-Reply-To: <fc4d8c34-1470-e82c-57e2-f623fcd65c85@sigaev.ru>
References: <13123421-1d52-d0e4-c95c-6d69011e0595@sigaev.ru>
<20180411194753.vhnwqss2hgqtao6v@alvherre.pgsql>
<CAPpHfds2etOsc-YSu+TKn05099wJrZPDg8yMhE460X3O6Zpaig@mail.gmail.com>
<CAH2-Wzkdg_StJuH9MtiiYA=WyJDk_1S2ZVtSPQz73hkKgBz2sQ@mail.gmail.com>
<352da91b-caeb-bbd9-cfe5-f477ad2628be@2ndquadrant.com>
<CAH2-Wzm0qH6BYaYGLFQB+Nz+O+g=k1Goe-ucdC2+8KhHG2KPfQ@mail.gmail.com>
<fc4d8c34-1470-e82c-57e2-f623fcd65c85@sigaev.ru>
Thanks to everyone, this part is pushed. I will waiting a bit before pushing
topic-stater patch to have a time to look on buildfarm.
Alvaro, could you add a comment to CompareIndexInfo() to clarify why it doesn't
compare indoptions (like DESC/ASC etc)? It doesn't matter for uniqueness of
index but changes an order and it's not clear at least for me why we don't pay
attention for that.
> In attached path I did:
> 1) fix a bug in CompareIndexInfo() which checks opfamily for including column
> 2) correct size for all vectors
> 3) Add assertion in various places to be sure that we don't try to use including
> column as key column
> 4) per Peter Geoghegan idea add a error message if somebody adds options to
> include column instead silently ignore it.
>
>
--
Teodor Sigaev E-mail: teodor@sigaev.ru
WWW: http://www.sigaev.ru/
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: teodor@sigaev.ru, pg@bowt.ie, peter.eisentraut@2ndquadrant.com, a.korotkov@postgrespro.ru, alvherre@alvh.no-ip.org, Langote_Amit_f8@lab.ntt.co.jp, jaime.casanova@2ndquadrant.com
Subject: Re: Partitioned tables and covering indexes
In-Reply-To: <4cfeb27e-e777-94f3-11eb-71fd070d3205@sigaev.ru>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox