public inbox for [email protected]  

help / color / mirror / Atom feed

From: Heikki Linnakangas <[email protected]>
To: Haibo Yan <[email protected]>
To: jian he <[email protected]>
Cc: Andreas Karlsson <[email protected]>
Cc: PostgreSQL-development <[email protected]>
Subject: Re: refactor ExecInitPartitionInfo
Date: Mon, 6 Jul 2026 14:03:11 +0300
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <CACJufxEN_mmgTtp-raJ9-VJHgyAGmb0SrO+01kn5by4mJ_XOfw@mail.gmail.com>
	<CACJufxGcUztOYcCj85o15YT68qPY3qpwUtdndqDgOs_Sps6Cow@mail.gmail.com>
	<[email protected]>
	<CACJufxFX_pTuBnQKoDP56ChcRiYdN+54KZnf99vo7MqVWrXmYw@mail.gmail.com>
	<[email protected]>

On 03/04/2026 01:19, Haibo Yan wrote:
>> On Apr 1, 2026, at 6:12 AM, jian he <[email protected]> wrote:
>> Ok. I switched it back to
>>
>> +    if (node &&
>> +        (node->withCheckOptionLists != NIL ||
>> +         node->returningLists != NIL ||
>> +         node->onConflictAction == ONCONFLICT_UPDATE ||
>> +         node->onConflictWhere ||
>> +         node->operation == CMD_MERGE))
>> +    {
>> +        /* later map_variable_attnos need use attribute map, build it 
>> now */
>> +        part_attmap = build_attrmap_by_name(RelationGetDescr(partrel),
>> + 
>>                                            RelationGetDescr(firstResultRel),
>> +                                            false);
>> +    }
>> +
>
> Hi Jian,
> 
> Thanks for working on this.
> 
> I’m not convinced this refactoring buys us much in its current form.

+1, for all the reasons you said. I have marked this as rejected in the 
commitfest app. Thanks!

- Heikki

view thread (7+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: refactor ExecInitPartitionInfo
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox