pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Jacob Champion <pchampion@vmware.com>
To: john.naylor@enterprisedb.com <john.naylor@enterprisedb.com>
Cc: pavel.stehule@gmail.com <pavel.stehule@gmail.com>
Cc: laurenz.albe@cybertec.at <laurenz.albe@cybertec.at>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Cc: michael@paquier.xyz <michael@paquier.xyz>
Cc: horikyota.ntt@gmail.com <horikyota.ntt@gmail.com>
Subject: Re: badly calculated width of emoji in psql
Date: Thu, 12 Aug 2021 22:34:57 +0000
Message-ID: <4def9e3159ab4ba475802e74c6ac3bce58dcb58f.camel@vmware.com> (raw)
In-Reply-To: <CAFBsxsFQ=scF=hgvrUWwDBzf1ZSkdmq1XRN4NJPMtniqNfpBCQ@mail.gmail.com>
References: <CAFj8pRCeX21O69YHxmykYySYyprZAqrKWWg0KoGKdjgqcGyygg@mail.gmail.com>
	<1f89b5e9624e08f1f06d7272bc880961860ff378.camel@cybertec.at>
	<CAFj8pRDuNNPJ-Xzd8ZC3dF4pbOsAZAH-zbA0Y65uivTZ2zT1ZQ@mail.gmail.com>
	<20210405.140718.90372987296815422.horikyota.ntt@gmail.com>
	<9e3c847108bac6041f50e86d08d8835f5cf7cd78.camel@vmware.com>
	<YPUtzT0J8cZByTkD@paquier.xyz>
	<f6a06ecdf378b50ed871e363aa9ac7e706101ab6.camel@cybertec.at>
	<c2a556a0158b642d6c597508d2a47059091e4d56.camel@vmware.com>
	<2f7ca10c7847f69267685beca7b5aa92dd876259.camel@vmware.com>
	<CAFj8pRCuaHgxa8M_FxmhGDg46qWp4yF-Xz_Xkj5NZT-F9fkQ1w@mail.gmail.com>
	<CAFBsxsEW0oAD2gdWQ9OQ8dS52iz476kWK2pqV1xmGuVjaygZTA@mail.gmail.com>
	<bedc833c3f60bbcd72ce613fc6a677be609d19dd.camel@vmware.com>
	<CAFBsxsGZTwzDnTs=TVM38CCTPP3Y0D3=h+UiWt8M83D5THHf9A@mail.gmail.com>
	<CAFBsxsFQ=scF=hgvrUWwDBzf1ZSkdmq1XRN4NJPMtniqNfpBCQ@mail.gmail.com>

On Thu, 2021-08-12 at 17:13 -0400, John Naylor wrote:
> The patch looks pretty good to me. I just have a stylistic suggestion
> which I've attached as a text file.

Getting rid of the "clever addition" looks much better to me, thanks. I
haven't verified the changes to the doc comment, but your description
seems reasonable.

> I'm a bit concerned about the build dependencies not working right,
> but it's not clear it's even due to the patch. I'll spend some time
> investigating next week.

If I vandalize src/common/wchar.c on HEAD, say by deleting the contents
of pg_wchar_table, and then run `make install`, then libpq doesn't get
rebuilt and there's no effect on the frontend. The postgres executable
does get rebuilt for the backend.

It looks like src/interfaces/libpq/Makefile doesn't have a dependency
on libpgcommon (or libpgport, for that matter). For comparison,
src/backend/Makefile has this:

    OBJS = \
        $(LOCALOBJS) \
        $(SUBDIROBJS) \
        $(top_builddir)/src/common/libpgcommon_srv.a \
        $(top_builddir)/src/port/libpgport_srv.a

So I think that's a bug that needs to be fixed independently, whether
this patch goes in or not.

--Jacob


view thread (37+ messages)  latest in thread

Message-ID: <4def9e3159ab4ba475802e74c6ac3bce58dcb58f.camel@vmware.com>
Permalink:  ../4def9e3159ab4ba475802e74c6ac3bce58dcb58f.camel@vmware.com/
Also on:    postgresql.org/message-id/4def9e3159ab4ba475802e74c6ac3bce58dcb58f.camel@vmware.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-hackers@postgresql.org
  Cc: pchampion@vmware.com, john.naylor@enterprisedb.com, pavel.stehule@gmail.com, laurenz.albe@cybertec.at, michael@paquier.xyz, horikyota.ntt@gmail.com
  Subject: Re: badly calculated width of emoji in psql
  In-Reply-To: <4def9e3159ab4ba475802e74c6ac3bce58dcb58f.camel@vmware.com>
  References: <CAFj8pRCeX21O69YHxmykYySYyprZAqrKWWg0KoGKdjgqcGyygg@mail.gmail.com> <1f89b5e9624e08f1f06d7272bc880961860ff378.camel@cybertec.at> <CAFj8pRDuNNPJ-Xzd8ZC3dF4pbOsAZAH-zbA0Y65uivTZ2zT1ZQ@mail.gmail.com> <20210405.140718.90372987296815422.horikyota.ntt@gmail.com> <9e3c847108bac6041f50e86d08d8835f5cf7cd78.camel@vmware.com> <YPUtzT0J8cZByTkD@paquier.xyz> <f6a06ecdf378b50ed871e363aa9ac7e706101ab6.camel@cybertec.at> <c2a556a0158b642d6c597508d2a47059091e4d56.camel@vmware.com> <2f7ca10c7847f69267685beca7b5aa92dd876259.camel@vmware.com> <CAFj8pRCuaHgxa8M_FxmhGDg46qWp4yF-Xz_Xkj5NZT-F9fkQ1w@mail.gmail.com> <CAFBsxsEW0oAD2gdWQ9OQ8dS52iz476kWK2pqV1xmGuVjaygZTA@mail.gmail.com> <bedc833c3f60bbcd72ce613fc6a677be609d19dd.camel@vmware.com> <CAFBsxsGZTwzDnTs=TVM38CCTPP3Y0D3=h+UiWt8M83D5THHf9A@mail.gmail.com> <CAFBsxsFQ=scF=hgvrUWwDBzf1ZSkdmq1XRN4NJPMtniqNfpBCQ@mail.gmail.com> <4def9e3159ab4ba475802e74c6ac3bce58dcb58f.camel@vmware.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox