public inbox for [email protected]  

help / color / mirror / Atom feed

From: Peter Eisentraut <[email protected]>
To: Nazir Bilal Yavuz <[email protected]>
To: Andres Freund <[email protected]>
Cc: pgsql-hackers <[email protected]>
Subject: Re: meson: Non-feature feature options
Date: Wed, 22 Feb 2023 10:14:05 +0100
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAN55FZ2Bz5P_sd2+1KBwWa9v4vDByM2UX7rKfzQs7yj6buojsg@mail.gmail.com>
References: <[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<CAN55FZ2Bz5P_sd2+1KBwWa9v4vDByM2UX7rKfzQs7yj6buojsg@mail.gmail.com>

On 21.02.23 17:32, Nazir Bilal Yavuz wrote:
>>> I like the second approach, with a 'uuid' feature option.  As you wrote
>>> earlier, adding an 'auto' choice to a combo option doesn't work fully like a
>>> real feature option.
>> But we can make it behave exactly like one, by checking the auto_features
>> option.
> Yes, we can set it like `uuidopt = get_option('auto_features')`.
> However, if someone wants to set 'auto_features' to 'disabled' but
> 'uuid' to 'enabled'(to find at least one working uuid library); this
> won't be possible. We can add 'enabled', 'disabled and 'auto' choices
> to 'uuid' combo option to make all behaviours possible but adding
> 'uuid' feature option and 'uuid_library' combo option seems better to
> me.

I think the uuid side of this is making this way too complicated.  I'm 
content leaving this as a manual option for now.

There is much more value in making the ssl option work automatically. 
So I would welcome a patch that just makes -Dssl=auto work smoothly, 
perhaps using the "trick" that Andres described.

view thread (8+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: meson: Non-feature feature options
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox