public inbox for [email protected]  

help / color / mirror / Atom feed

From: Peter Eisentraut <[email protected]>
To: Tom Lane <[email protected]>
Cc: Andres Freund <[email protected]>
Cc: [email protected]
Subject: Re: convert libpq uri-regress tests to tap test
Date: Thu, 24 Feb 2022 00:21:36 +0100
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<[email protected]>

On 23.02.22 23:58, Tom Lane wrote:
> Peter Eisentraut <[email protected]> writes:
>> On 23.02.22 21:30, Andres Freund wrote:
>>> Where would we want that test to live? Right now we have the slightly odd
>>> convention that some tap tests live in src/test/{misc,modules,...}. But
>>> e.g. frontend binary ones are below src/bin/.
> 
>> libpq TAP tests should be in src/interfaces/libpq/t/.
> 
>> I think there were issues that the build farm wouldn't pick up a test
>> located there, but that should be fixed rather than worked around.
> 
> That's failing to account for the fact that a libpq test can't
> really be a pure-perl TAP test; you need some C code to drive the
> library.  I don't agree with intermixing such code with libpq
> itself, independently of any buildsystem issues (which there
> might well be).

Such things could be put under src/interfaces/libpq/test, or some other 
subdirectory.  We already have src/interfaces/ecpg/test.

> So I think the design of putting such tests under
> src/modules is fine.

I don't get what the rationale for that would be.  libpq tests are not 
"modules" of any kind.

If I'm working on libpq, I want to do make && make check inside the 
libpq source directory.

view thread (7+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: convert libpq uri-regress tests to tap test
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox