public inbox for [email protected]help / color / mirror / Atom feed
[PATCH v6 06/10] doc: Add logical replication support to replicate into partitioned tables 8+ messages / 5 participants [nested] [flat]
* [PATCH v6 06/10] doc: Add logical replication support to replicate into partitioned tables @ 2020-04-10 15:05 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 8+ messages in thread From: Justin Pryzby @ 2020-04-10 15:05 UTC (permalink / raw) commit f1ac27bfda6ce8a399d8001843e9aefff5814f9b Author: Peter Eisentraut <[email protected]> --- doc/src/sgml/logical-replication.sgml | 2 +- src/backend/replication/logical/relation.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/src/sgml/logical-replication.sgml b/doc/src/sgml/logical-replication.sgml index 3f69b71926..d2cdd13c58 100644 --- a/doc/src/sgml/logical-replication.sgml +++ b/doc/src/sgml/logical-replication.sgml @@ -404,7 +404,7 @@ <para> Replication is only supported by tables, including partitioned tables. Attempts to replicate other types of relations such as views, materialized - views, or foreign tables, will result in an error. + views, or foreign tables will result in an error. </para> </listitem> diff --git a/src/backend/replication/logical/relation.c b/src/backend/replication/logical/relation.c index a60c73d74d..e1a447e097 100644 --- a/src/backend/replication/logical/relation.c +++ b/src/backend/replication/logical/relation.c @@ -631,7 +631,7 @@ logicalrep_partition_open(LogicalRepRelMapEntry *root, /* * If the partition's attributes don't match the root relation's, we'll * need to make a new attrmap which maps partition attribute numbers to - * remoterel's, instead the original which maps root relation's attribute + * remoterel's, instead of the original which maps root relation's attribute * numbers to remoterel's. * * Note that 'map' which comes from the tuple routing data structure -- 2.17.0 --C+ts3FVlLX8+P6JN Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v6-0007-is-vs-are-plural.patch" ^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: meson documentation build open issues @ 2023-04-05 10:24 Peter Eisentraut <[email protected]> 0 siblings, 1 reply; 8+ messages in thread From: Peter Eisentraut @ 2023-04-05 10:24 UTC (permalink / raw) To: pgsql-hackers; +Cc: Andres Freund <[email protected]> On 15.03.23 08:14, Peter Eisentraut wrote: > I have identified several open issues with the documentation build under > Meson (approximately in priority order): Some work has been done on this. Here is my current assessment. > 1. Image files are not handled at all, so they don't show up in the > final product. This is fixed. > 2. Defaults to website stylesheet, no way to configure. This should be > adjusted to match the make build. This is fixed. > 3. The various build targets and their combinations are mismatching and > incomplete. This has been improved, and I see there is documentation. I think it's still an issue that "make docs" builds html and man but "ninja docs" only builds html. For some reason the wiki page actually claims that ninja docs builds both, but this does not happen for me. > 4. There doesn't appear to be a way to install the documentation. This has been addressed. > 5. There doesn't appear to be an equivalent of "make world" and "make > install-world" that includes documentation builds. This has been addressed with the additional meson auto options. But it seems that these options only control building, not installing, so there is no "install-world" aspect yet. ^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: meson documentation build open issues @ 2023-04-05 14:45 Andres Freund <[email protected]> parent: Peter Eisentraut <[email protected]> 0 siblings, 1 reply; 8+ messages in thread From: Andres Freund @ 2023-04-05 14:45 UTC (permalink / raw) To: Peter Eisentraut <[email protected]>; Tom Lane <[email protected]>; +Cc: pgsql-hackers Hi, On 2023-04-05 12:24:04 +0200, Peter Eisentraut wrote: > On 15.03.23 08:14, Peter Eisentraut wrote: > > 3. The various build targets and their combinations are mismatching and > > incomplete. > > This has been improved, and I see there is documentation. > > I think it's still an issue that "make docs" builds html and man but "ninja > docs" only builds html. For some reason the wiki page actually claims that > ninja docs builds both, but this does not happen for me. It used to, but Tom insisted that it should not. I'm afraid that it's not quite possible to emulate make here. 'make docs' at the toplevel builds both HTML and manpages. But 'make -C doc/src/sgml', only builds HTML. > > 5. There doesn't appear to be an equivalent of "make world" and "make > > install-world" that includes documentation builds. > > This has been addressed with the additional meson auto options. But it > seems that these options only control building, not installing, so there is > no "install-world" aspect yet. I'm not following - install-world install docs if the docs feature is available, and not if not? Greetings, Andres Freund ^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: meson documentation build open issues @ 2023-04-06 09:11 Peter Eisentraut <[email protected]> parent: Andres Freund <[email protected]> 0 siblings, 1 reply; 8+ messages in thread From: Peter Eisentraut @ 2023-04-06 09:11 UTC (permalink / raw) To: Andres Freund <[email protected]>; Tom Lane <[email protected]>; +Cc: pgsql-hackers On 05.04.23 16:45, Andres Freund wrote: >> I think it's still an issue that "make docs" builds html and man but "ninja >> docs" only builds html. For some reason the wiki page actually claims that >> ninja docs builds both, but this does not happen for me. > > It used to, but Tom insisted that it should not. I'm afraid that it's not > quite possible to emulate make here. 'make docs' at the toplevel builds both > HTML and manpages. But 'make -C doc/src/sgml', only builds HTML. Ok, not a topic for this thread then. >>> 5. There doesn't appear to be an equivalent of "make world" and "make >>> install-world" that includes documentation builds. >> >> This has been addressed with the additional meson auto options. But it >> seems that these options only control building, not installing, so there is >> no "install-world" aspect yet. > > I'm not following - install-world install docs if the docs feature is > available, and not if not? I had expected that if meson setup enables the 'docs' feature, then meson compile will build the documentation, which happens, and meson install will install it, which does not happen. ^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: meson documentation build open issues @ 2023-04-07 14:39 Andrew Dunstan <[email protected]> parent: Peter Eisentraut <[email protected]> 0 siblings, 1 reply; 8+ messages in thread From: Andrew Dunstan @ 2023-04-07 14:39 UTC (permalink / raw) To: Peter Eisentraut <[email protected]>; Andres Freund <[email protected]>; Tom Lane <[email protected]>; +Cc: pgsql-hackers On 2023-04-06 Th 05:11, Peter Eisentraut wrote: > On 05.04.23 16:45, Andres Freund wrote: >>> I think it's still an issue that "make docs" builds html and man but >>> "ninja >>> docs" only builds html. For some reason the wiki page actually >>> claims that >>> ninja docs builds both, but this does not happen for me. >> >> It used to, but Tom insisted that it should not. I'm afraid that it's >> not >> quite possible to emulate make here. 'make docs' at the toplevel >> builds both >> HTML and manpages. But 'make -C doc/src/sgml', only builds HTML. > > Ok, not a topic for this thread then. > >>>> 5. There doesn't appear to be an equivalent of "make world" and "make >>>> install-world" that includes documentation builds. >>> >>> This has been addressed with the additional meson auto options. But it >>> seems that these options only control building, not installing, so >>> there is >>> no "install-world" aspect yet. >> >> I'm not following - install-world install docs if the docs feature is >> available, and not if not? > > I had expected that if meson setup enables the 'docs' feature, then > meson compile will build the documentation, which happens, and meson > install will install it, which does not happen. > > > "meson compile" doesn't seem to build the docs by default ( see <https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=crake&dt=2023-04-06%2018%3A17%3A04...;), and I'd rather it didn't, building the docs is a separate and optional step for the buildfarm. cheers andrew -- Andrew Dunstan EDB:https://www.enterprisedb.com ^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: meson documentation build open issues @ 2023-04-12 15:30 Peter Eisentraut <[email protected]> parent: Andrew Dunstan <[email protected]> 0 siblings, 1 reply; 8+ messages in thread From: Peter Eisentraut @ 2023-04-12 15:30 UTC (permalink / raw) To: Andrew Dunstan <[email protected]>; Andres Freund <[email protected]>; Tom Lane <[email protected]>; +Cc: pgsql-hackers On 07.04.23 16:39, Andrew Dunstan wrote: >>>>> 5. There doesn't appear to be an equivalent of "make world" and "make >>>>> install-world" that includes documentation builds. >>>> >>>> This has been addressed with the additional meson auto options. But it >>>> seems that these options only control building, not installing, so >>>> there is >>>> no "install-world" aspect yet. >>> >>> I'm not following - install-world install docs if the docs feature is >>> available, and not if not? >> >> I had expected that if meson setup enables the 'docs' feature, then >> meson compile will build the documentation, which happens, and meson >> install will install it, which does not happen. > > "meson compile" doesn't seem to build the docs by default ( see > <https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=crake&dt=2023-04-06%2018%3A17%3A04...;), and I'd rather it didn't, building the docs is a separate and optional step for the buildfarm. You can control this with the "docs" option for meson, as of recently. ^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: meson documentation build open issues @ 2023-11-03 14:26 Christoph Berg <[email protected]> parent: Peter Eisentraut <[email protected]> 0 siblings, 1 reply; 8+ messages in thread From: Christoph Berg @ 2023-11-03 14:26 UTC (permalink / raw) To: Peter Eisentraut <[email protected]>; +Cc: Andrew Dunstan <[email protected]>; Andres Freund <[email protected]>; Tom Lane <[email protected]>; pgsql-hackers Re: Peter Eisentraut > > "meson compile" doesn't seem to build the docs by default ( see <https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=crake&dt=2023-04-06%2018%3A17%3A04...;), > > and I'd rather it didn't, building the docs is a separate and optional > > step for the buildfarm. > > You can control this with the "docs" option for meson, as of recently. I've been looking into switching the Debian PG 17 build to meson, but I'm running into several problems. * The docs are still not built by default, and -Ddocs=enabled doesn't change that * None of the "build docs" targets are documented in install-meson.html * "ninja -C build alldocs" works, but it's impossible to see what flavors it's actually building. Everything is autodetected, and perhaps I would like to no build the .txt/something variants, but I have no idea what switch that is, or what package I have to uninstall so it's not autodetected (only html and pdf are documented.) Are there any other targets for the individual formats? (I could probably use one for the manpages only, without the html.) Non-doc issues: * LLVM is off by default (ok), when I enable it with -Dllvm=auto, it gets detected, but no .bc files are built, nor installed * selinux is not autodetected. It needs -Dselinux=auto, but that's not documented in install-meson.html * There is no split between libdir and pkglibdir. We had used that in the past for libpq -> /usr/lib/x86_64-linux-gnu and PG stuff -> /usr/lib/postgresql/17/lib. Christoph ^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: meson documentation build open issues @ 2023-11-03 16:38 Andres Freund <[email protected]> parent: Christoph Berg <[email protected]> 0 siblings, 0 replies; 8+ messages in thread From: Andres Freund @ 2023-11-03 16:38 UTC (permalink / raw) To: Christoph Berg <[email protected]>; Peter Eisentraut <[email protected]>; Andrew Dunstan <[email protected]>; Tom Lane <[email protected]>; pgsql-hackers Hi, On 2023-11-03 15:26:05 +0100, Christoph Berg wrote: > Re: Peter Eisentraut > > > "meson compile" doesn't seem to build the docs by default ( see <https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=crake&dt=2023-04-06%2018%3A17%3A04...;), > > > and I'd rather it didn't, building the docs is a separate and optional > > > step for the buildfarm. > > > > You can control this with the "docs" option for meson, as of recently. > > I've been looking into switching the Debian PG 17 build to meson, but > I'm running into several problems. > > * The docs are still not built by default, and -Ddocs=enabled doesn't > change that Maybe I am missing something - they aren't built by default in autoconf either? > * None of the "build docs" targets are documented in install-meson.html Hm, odd, I thought they were, but you are right. There were some docs patches that we never really could find agreement upon :/ > * "ninja -C build alldocs" works, but it's impossible to see what > flavors it's actually building. Everything is autodetected, and > perhaps I would like to no build the .txt/something variants, > but I have no idea what switch that is, or what package I have to > uninstall so it's not autodetected (only html and pdf are > documented.) I think a package build should probably turn off auto-detection ( meson setup --auto-features=disabled) and enable specific features that are desired - in which case you get errors if they are not available. Which presumably is the behaviour you'd like? > Are there any other targets for the individual formats? (I could > probably use one for the manpages only, without the html.) Yes, there are. ninja doc/src/sgml/{postgres-A4.pdf,html,postgres.html,man1} Perhaps more interesting for your purposes, there are the install-doc-{html,man} targets. I remember discussing adding doc-{html,man} targets alongside install-doc-{html,man}, not sure why we ended up not doing that. I'd be in favor of adding them. I've also been wondering about a 'help' target that documents important targets in a interactively usable way. > Non-doc issues: > > * LLVM is off by default (ok), when I enable it with -Dllvm=auto, it > gets detected, but no .bc files are built, nor installed Support for that has not yet been merged. > * selinux is not autodetected. It needs -Dselinux=auto, but that's not > documented in install-meson.html Uh, huh. There's no documentation for --with-selinux in the installation.sgml either, just in sepgsql.sgml. So when the relevant docs got translated to meson, -Dselinux= wasn't documented either. > * There is no split between libdir and pkglibdir. We had used that in > the past for libpq -> /usr/lib/x86_64-linux-gnu and PG stuff -> > /usr/lib/postgresql/17/lib. I don't think the autoconf build currently exposes separately configuring pkglibdir either, I think that's a debian patch? I'm entirely open to adding an explicit configuration option for this though. Thanks for looking at this, it's quite helpful! Greetings, Andres Freund ^ permalink raw reply [nested|flat] 8+ messages in thread
end of thread, other threads:[~2023-11-03 16:38 UTC | newest] Thread overview: 8+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2020-04-10 15:05 [PATCH v6 06/10] doc: Add logical replication support to replicate into partitioned tables Justin Pryzby <[email protected]> 2023-04-05 10:24 Re: meson documentation build open issues Peter Eisentraut <[email protected]> 2023-04-05 14:45 ` Re: meson documentation build open issues Andres Freund <[email protected]> 2023-04-06 09:11 ` Re: meson documentation build open issues Peter Eisentraut <[email protected]> 2023-04-07 14:39 ` Re: meson documentation build open issues Andrew Dunstan <[email protected]> 2023-04-12 15:30 ` Re: meson documentation build open issues Peter Eisentraut <[email protected]> 2023-11-03 14:26 ` Re: meson documentation build open issues Christoph Berg <[email protected]> 2023-11-03 16:38 ` Re: meson documentation build open issues Andres Freund <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox