pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: Jacob Champion <pchampion@vmware.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Cc: Daniel Gustafsson <daniel@yesql.se>
Cc: info@cspug.cz
Subject: Re: Preventing abort() and exit() calls in libpq
Date: Tue, 29 Jun 2021 16:39:28 -0400
Message-ID: <503095.1624999168@sss.pgh.pa.us> (raw)
In-Reply-To: <451278.1624986930@sss.pgh.pa.us>
References: <3128896.1624742969@sss.pgh.pa.us>
	<340320.1624912475@sss.pgh.pa.us>
	<451278.1624986930@sss.pgh.pa.us>

I wrote:
> So I pushed that, and not very surprisingly, it's run into some
> portability problems.  gombessa (recent OpenBSD) reports

> ! nm -A -g -u libpq.so.5.15 2>/dev/null | grep -v '_eprintf\\.o:' | grep -e abort -e exit
> libpq.so.5.15:__cxa_atexit

After a few more hours, all of our OpenBSD animals have reported
that, on several different OpenBSD releases and with both gcc
and clang compilers.  So at least it's a longstanding platform
behavior.

More troublingly, fossa reports this:

! nm -A -g -u libpq.so.5.15 2>/dev/null | grep -v '_eprintf\\.o:' | grep -e abort -e exit
libpq.so.5.15:                 U abort@@GLIBC_2.2.5

Where is that coming from?  hippopotamus and jay, which seem to
be different compilers on the same physical machine, aren't showing
it.  That'd lead to the conclusion that icc is injecting abort()
calls of its own accord, which seems quite nasty.  Lacking an icc
license, I can't poke into that more directly here.

Perhaps we could wrap the test for abort() in something like
'if "$CC" != icc then ...', but ugh.

			regards, tom lane





view thread (57+ messages)  latest in thread

Message-ID: <503095.1624999168@sss.pgh.pa.us>
Permalink:  ../503095.1624999168@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/503095.1624999168@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, michael@paquier.xyz, pchampion@vmware.com, daniel@yesql.se, info@cspug.cz
  Subject: Re: Preventing abort() and exit() calls in libpq
  In-Reply-To: <503095.1624999168@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox