pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Jacob Champion <pchampion@vmware.com>
To: peter.eisentraut@enterprisedb.com <peter.eisentraut@enterprisedb.com>
To: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: SSL SNI
Date: Thu, 3 Jun 2021 17:25:24 +0000
Message-ID: <504c276ab6eee000bb23d571ea9b0ced4250774e.camel@vmware.com> (raw)
In-Reply-To: <4bf3ae1c-b28e-8960-e89f-c390c5cf01a2@enterprisedb.com>
References: <7289d5eb-62a5-a732-c3b9-438cee2cb709@enterprisedb.com>
	<ef3d4b460ae7da59a8811f4e8e8fde0cd38a6cc8.camel@vmware.com>
	<9407b344-7342-b2b7-004f-d5250687be42@enterprisedb.com>
	<ecb6a57d176a396feb959fbb0c53b3c794e8d8e5.camel@vmware.com>
	<4eaa2b56-c3d0-67b6-4716-010d001c7601@enterprisedb.com>
	<4bf3ae1c-b28e-8960-e89f-c390c5cf01a2@enterprisedb.com>

On Wed, 2021-04-07 at 15:32 +0200, Peter Eisentraut wrote:
> Committed like that.  (Default to on, but it's easy to change if there 
> are any further thoughts.)

Hi Peter,

It looks like this code needs some guards for a NULL conn->pghost. For example when running

    psql 'dbname=postgres sslmode=require hostaddr=127.0.0.1'
with no PGHOST in the environment, psql is currently segfaulting for
me.

--Jacob


view thread (24+ messages)  latest in thread

Message-ID: <504c276ab6eee000bb23d571ea9b0ced4250774e.camel@vmware.com>
Permalink:  ../504c276ab6eee000bb23d571ea9b0ced4250774e.camel@vmware.com/
Also on:    postgresql.org/message-id/504c276ab6eee000bb23d571ea9b0ced4250774e.camel@vmware.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: pchampion@vmware.com, peter.eisentraut@enterprisedb.com
  Subject: Re: SSL SNI
  In-Reply-To: <504c276ab6eee000bb23d571ea9b0ced4250774e.camel@vmware.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox