pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Greg Smith <greg@2ndquadrant.com>
Cc: Fujii Masao <masao.fujii@gmail.com>
Cc: Magnus Hagander <magnus@hagander.net>
Cc: pgsql-hackers@postgresql.org
Subject: Re: auto-sizing wal_buffers
Date: Sat, 22 Jan 2011 21:24:48 -0500
Message-ID: <508.1295749488@sss.pgh.pa.us> (raw)
In-Reply-To: <AANLkTimR1qFAib3gaJ8q5CtHyPGqkT9-E=CcScUOBbfs@mail.gmail.com>
References: <AANLkTik3mZ3sTfbHQW-1B44NRMkUzRsMnPb8g-HtttVv@mail.gmail.com>
	<AANLkTimQ3+osgAEH4meS97FmLN-4evSTS2W6fctov=jY@mail.gmail.com>
	<AANLkTinhU9EEPGM29S+KH=qK4t-mLhBBNAaLCGQSx-4y@mail.gmail.com>
	<20767.1294964709@sss.pgh.pa.us>
	<4D314406.3000703@2ndquadrant.com>
	<AANLkTikoUWemGmAmNGHXW8QQoo45sLxzr-aU=rUwshba@mail.gmail.com>
	<4D31D0E4.9000108@2ndquadrant.com>
	<AANLkTikpeVE-XMZL4L4Mi4zUd7S-D1JckO97_wjp8t3M@mail.gmail.com>
	<11561.1295742146@sss.pgh.pa.us>
	<29279.1295746434@sss.pgh.pa.us>
	<AANLkTin93Pfat3RX9u1zWdnZMraQdTzRPC3kE__BUaiD@mail.gmail.com>
	<AANLkTi=7ZVAD+iDm9RTgg-XiZWU47_dBo9Ev6Xvrwf3_@mail.gmail.com>
	<202.1295748502@sss.pgh.pa.us>
	<AANLkTimR1qFAib3gaJ8q5CtHyPGqkT9-E=CcScUOBbfs@mail.gmail.com>

Robert Haas <robertmhaas@gmail.com> writes:
> I'm going with hacks.  Any API that requires you to print to a string
> so you can turn around and immediately convert it back to an integer
> is not too swift.

Oh, you're complaining about SetConfigOption, not the assign hooks.

Not sure if it's really worth refactoring that.  The problem is that
there are lots and lots and lots of places that need to call that
*without* any dependency on what the datatype of the target GUC option
really is.  There are a small number where we do know the type and
conversion to a string is just overhead.  If any of those were
performance-critical it might be worth worrying about, but this one
certainly isn't.

			regards, tom lane



view thread (37+ messages)  latest in thread

Message-ID: <508.1295749488@sss.pgh.pa.us>
Permalink:  ../508.1295749488@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/508.1295749488@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, robertmhaas@gmail.com, greg@2ndquadrant.com, masao.fujii@gmail.com, magnus@hagander.net
  Subject: Re: auto-sizing wal_buffers
  In-Reply-To: <508.1295749488@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox