From: Tom Lane <tgl@sss.pgh.pa.us>
To: Fabien COELHO <coelho@cri.ensmp.fr>
Cc: PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Subject: Re: libpq connection timeout mismanagement
Date: Tue, 14 Aug 2018 13:17:12 -0400
Message-ID: <5106.1534267032@sss.pgh.pa.us> (raw)
In-Reply-To: <alpine.DEB.2.21.1808140909250.27691@lancre>
References: <5735.1533828184@sss.pgh.pa.us>
<alpine.DEB.2.21.1808111611040.30788@lancre>
<20525.1534180589@sss.pgh.pa.us>
<alpine.DEB.2.21.1808140909250.27691@lancre>
Fabien COELHO <coelho@cri.ensmp.fr> writes:
>> Right. As before, I'm not excited about rejecting trailing junk,
>> considering we never did before.
> My 0.02ยค: accepting trailing junk is just a recipee for hiding bugs:
> sh> psql "connect_timeout=2,port=5433"
> psql> \conninfo
> ... port=5432 # port directive was silently ignored
> So erroring out would be a good thing, and it could be done on a new
> release.
Perhaps. That should certainly be a separate patch, though, and
it should cover everything not just connection_timeout (I see at
least five parameters that are parsed with atoi() and nothing else).
I'm still not excited, but feel free to send a patch.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, coelho@cri.ensmp.fr, pgsql-hackers@lists.postgresql.org
Subject: Re: libpq connection timeout mismanagement
In-Reply-To: <5106.1534267032@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox