pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Stephen Frost <sfrost@snowman.net>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Laurenz Albe <laurenz.albe@cybertec.at>
Cc: Bossart, Nathan <bossartn@amazon.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Bernd Helmle <mailings@oopsware.de>
Cc: tsunakawa.takay@fujitsu.com <tsunakawa.takay@fujitsu.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: Change default of checkpoint_completion_target
Date: Tue, 19 Jan 2021 14:30:46 -0500
Message-ID: <519044.1611084646@sss.pgh.pa.us> (raw)
In-Reply-To: <20210119191450.GO27507@tamriel.snowman.net>
References: <20201210171602.GP16415@tamriel.snowman.net>
	<20201210172126.GA25979@alvherre.pgsql>
	<20201210172255.GQ16415@tamriel.snowman.net>
	<20210113221038.GG27507@tamriel.snowman.net>
	<ba8bb5e9-8c43-11b6-eb99-ae794cd37665@enterprisedb.com>
	<20210119191450.GO27507@tamriel.snowman.net>

Stephen Frost <sfrost@snowman.net> writes:
> Any further comments or thoughts on this one?

This:

+        total time between checkpoints. The default is 0.9, which spreads the
+        checkpoint across the entire checkpoint timeout period of time,

is confusing because 0.9 is obviously not 1.0; people will wonder
whether the scale is something strange or the text is just wrong.
They will also wonder why not use 1.0 instead.  So perhaps more like

	... The default is 0.9, which spreads the checkpoint across almost
	all the available interval, providing fairly consistent I/O load
	while also leaving some slop for checkpoint completion overhead.

The other chunk of text seems accurate, but there's no reason to let
this one be misleading.

			regards, tom lane





view thread (30+ messages)  latest in thread

Message-ID: <519044.1611084646@sss.pgh.pa.us>
Permalink:  ../519044.1611084646@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/519044.1611084646@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, sfrost@snowman.net, peter.eisentraut@enterprisedb.com, alvherre@alvh.no-ip.org, laurenz.albe@cybertec.at, bossartn@amazon.com, michael@paquier.xyz, mailings@oopsware.de, tsunakawa.takay@fujitsu.com
  Subject: Re: Change default of checkpoint_completion_target
  In-Reply-To: <519044.1611084646@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox