From: Jim Nasby <jim@nasby.net>
To: Greg Smith <greg@2ndQuadrant.com>
Cc: Amit Kapila <amit.kapila@huawei.com>
Cc: PostgreSQL-development <pgsql-hackers@postgreSQL.org>
Subject: Re: Move unused buffers to freelist
Date: Thu, 23 May 2013 16:16:45 -0500
Message-ID: <519E873D.5000406@nasby.net> (raw)
In-Reply-To: <51928CDA.7030009@2ndQuadrant.com>
References: <002f01ce50a8$e057c7a0$a10756e0$@kapila@huawei.com>
<51928CDA.7030009@2ndQuadrant.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
On 5/14/13 2:13 PM, Greg Smith wrote:
> It is possible that we are told to put something in the freelist that
> is already in it; don't screw up the list if so.
>
> I don't see where the code does anything to handle that though. What was your intention here?
IIRC, the code that pulls from the freelist already deals with the possibility that a block was on the freelist but has since been put to use. If that's the case then there shouldn't be much penalty to adding a block multiple times (at least within reason...)
--
Jim C. Nasby, Data Architect jim@nasby.net
512.569.9461 (cell) http://jim.nasby.net
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: jim@nasby.net, greg@2ndQuadrant.com, amit.kapila@huawei.com
Subject: Re: Move unused buffers to freelist
In-Reply-To: <519E873D.5000406@nasby.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox