pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed

From: Heikki Linnakangas <hlinnakangas@vmware.com>
To: Antonin Houska <antonin.houska@gmail.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: GIN improvements part 1: additional information
Date: Sat, 29 Jun 2013 12:00:04 +0300
Message-ID: <51CEA214.8090805@vmware.com> (raw)
In-Reply-To: <51CC4A44.2080905@gmail.com>
References: <CAPpHfduxv-iL7aedwPW0W5fXrWGAKfxijWM63_hZujaCRxnmFQ@mail.gmail.com>
	<CAPpHfduQrtC4B+MC9_z3QB8oJsK1Ws-H8ivEsy_cmDnfoJqkeQ@mail.gmail.com>
	<CAPpHfdszEJhSynTPX6=tB3aKq1EA1JXpwx4xiFYM097K7PhQLA@mail.gmail.com>
	<CAPpHfdu8=5spaS7c9mxwH7bNMDR6n378fZCv6c2Y3YM7iE5KiQ@mail.gmail.com>
	<51CC4A44.2080905@gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>

On 27.06.2013 17:20, Antonin Houska wrote:
> I was curious about the new layout of the data page, so I spent a while
> looking into the code.
> It's interesting, but I suspect 2 things are not o.k.:
>
> * gindatapage.c:dataIsEnoughSpace() - 'i++' in the for loop should
> probably be 'j++', otherwise it loops forever

Hmm. It won't loop forever, i is counting the number of entries that fit 
on the page, while j is used to loop through the items being added. 
However, i isn't actually used for anything (and isn't initialized 
either), so it's just dead code.

- Heikki


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

view thread (119+ messages)  latest in thread

Message-ID: <51CEA214.8090805@vmware.com>
Permalink:  ../51CEA214.8090805@vmware.com/
Also on:    postgresql.org/message-id/51CEA214.8090805@vmware.com

copy link · copy postgr.es

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: hlinnakangas@vmware.com, antonin.houska@gmail.com
  Subject: Re: GIN improvements part 1: additional information
  In-Reply-To: <51CEA214.8090805@vmware.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox