From: Heikki Linnakangas <hlinnakangas@vmware.com>
To: Alexander Korotkov <aekorotkov@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: GIN improvements part 1: additional information
Date: Sat, 29 Jun 2013 20:08:38 +0300
Message-ID: <51CF1496.9020106@vmware.com> (raw)
In-Reply-To: <51CEA13C.8040103@vmware.com>
References: <CAPpHfduxv-iL7aedwPW0W5fXrWGAKfxijWM63_hZujaCRxnmFQ@mail.gmail.com>
<CAPpHfduQrtC4B+MC9_z3QB8oJsK1Ws-H8ivEsy_cmDnfoJqkeQ@mail.gmail.com>
<CAPpHfdszEJhSynTPX6=tB3aKq1EA1JXpwx4xiFYM097K7PhQLA@mail.gmail.com>
<CAPpHfdu8=5spaS7c9mxwH7bNMDR6n378fZCv6c2Y3YM7iE5KiQ@mail.gmail.com>
<51CEA13C.8040103@vmware.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
On 29.06.2013 11:56, Heikki Linnakangas wrote:
> On 25.06.2013 01:03, Alexander Korotkov wrote:
>> New revision of patch is attached. Now it includes some docs.
>
> Thanks! I'm looking into this in detail now.
>
> First, this patch actually contains two major things:
>
> 1. Pack item pointers more tightly on posting data leaf pages.
> 2. Allow opclass implementation to attach "additional information" to
> each item pointer.
>
> These are two very distinct features, so this patch needs to be split
> into two. I extracted the 1st part into a separate patch, attached, and
> am going to focus on that now.
>
> I made one significant change: I removed the 'freespace' field you added
> to GinpageOpaque. Instead, on data leaf pages the offset from the
> beginning of the page where the packed items end is stored in place of
> the 'maxoff' field. This allows for quick calculation of the free space,
> but there is no count of item pointers stored on the page anymore, so
> some code that looped through all the item pointers relying on 'maxoff'
> had to be changed to work with the end offset instead. I'm not 100%
> wedded on this, but I'd like to avoid adding the redundant freespace
> field on pages that don't need it, because it's confusing and you have
> to remember to keep them in sync.
Ah, crap, looks like I sent the wrong patch, and now I can't find the
correct one anymore. The patch I sent didn't include the changes store
end offset instead of freespace. I'll rewrite that part..
- Heikki
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: hlinnakangas@vmware.com, aekorotkov@gmail.com
Subject: Re: GIN improvements part 1: additional information
In-Reply-To: <51CF1496.9020106@vmware.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox