From: Tom Lane <tgl@sss.pgh.pa.us>
To: Stephen Frost <sfrost@snowman.net>
Cc: Amit Kapila <amit.kapila16@gmail.com>
Cc: Ian Barwick <ian.barwick@2ndquadrant.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: [PATCH] Stop ALTER SYSTEM from making bad assumptions
Date: Sun, 16 Jun 2019 13:21:39 -0400
Message-ID: <5218.1560705699@sss.pgh.pa.us> (raw)
In-Reply-To: <20190616171610.GO2480@tamriel.snowman.net>
References: <aed6cc9f-98f3-2693-ac81-52bb0052307e@2ndquadrant.com>
<20190614160835.GF2480@tamriel.snowman.net>
<CAA4eK1JW9UfLOtMEJq5b_YcogbWdxzAGUzNi72F2Xx4r1_h6QA@mail.gmail.com>
<20190616171610.GO2480@tamriel.snowman.net>
Stephen Frost <sfrost@snowman.net> writes:
> Unless there's actually a use-case for duplicate entries in
> postgresql.auto.conf,
There isn't --- guc.c will just discard the earlier duplicates.
> what we should do is clean them up (and possibly
> throw a WARNING or similar at the user saying "something modified your
> postgresql.auto.conf in an unexpected way"). I'd suggest we do that on
> every ALTER SYSTEM call.
+1 for having ALTER SYSTEM clean out duplicates. Not sure whether
a WARNING would seem too in-your-face.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, sfrost@snowman.net, amit.kapila16@gmail.com, ian.barwick@2ndquadrant.com
Subject: Re: [PATCH] Stop ALTER SYSTEM from making bad assumptions
In-Reply-To: <5218.1560705699@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox