public inbox for [email protected]  

help / color / mirror / Atom feed

From: Peter Eisentraut <[email protected]>
To: Thomas Munro <[email protected]>
To: pgsql-hackers <[email protected]>
Subject: Re: Requiring LLVM 14+ in PostgreSQL 18
Date: Sun, 12 May 2024 16:32:59 +0200
Message-ID: <[email protected]> (raw)
In-Reply-To: <CA+hUKGLFNFMOPPME6mpkGeve0+6CRrZLMTKs+MmBGJp4vLcJ=A@mail.gmail.com>
References: <CA+hUKG+SOP-aR=YF_n0dtXGWeCy6x+Cn-RMWURU5ySQdmeKW1Q@mail.gmail.com>
	<CA+hUKGLXr0Rjz_6PQrNWe7Z-k7_G-MAHoh1DP+A-sxw0qpYEDQ@mail.gmail.com>
	<CA+hUKGLFNFMOPPME6mpkGeve0+6CRrZLMTKs+MmBGJp4vLcJ=A@mail.gmail.com>

On 24.04.24 01:43, Thomas Munro wrote:
> Rebased over ca89db5f.

These patches look fine to me.  The new cut-off makes sense, and it does 
save quite a bit of code.  We do need to get the Cirrus CI Debian images 
updated first, as you had already written.

As part of this patch, you also sneak in support for LLVM 18 
(llvm-config-18, clang-18 in configure).  Should this be a separate patch?

And as I'm looking up how this was previously handled, I notice that 
this list of clang-NN versions was last updated equally sneakily as part 
of your patch to trim off LLVM <10 (820b5af73dc).  I wonder if the 
original intention of that configure code was that maintaining the 
versioned list above clang-7/llvm-config-7 was not needed, because the 
unversioning programs could be used, or maybe because pkg-config could 
be used.  It would be nice if we could get rid of having to update that.

view thread (18+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: Requiring LLVM 14+ in PostgreSQL 18
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox