From: KONDO Mitsumasa <kondo.mitsumasa@lab.ntt.co.jp>
To: Pavel Stehule <pavel.stehule@gmail.com>
Cc: FabrÃzio Mello <fabriziomello@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Simon Riggs <simon@2ndquadrant.com>
Cc: Pgsql Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Time-Delayed Standbys
Date: Mon, 09 Dec 2013 19:54:53 +0900
Message-ID: <52A5A17D.5010504@lab.ntt.co.jp> (raw)
In-Reply-To: <CAFj8pRA_9SssJuictTLwoc0EGNEoYADZ1dCVW9UV4TKwi=4Zzw@mail.gmail.com>
References: <CAFcNs+oXq5ZPaKARRn3VZGzX+AnTZCaEjR6VmQT_tvoFiqgaSg@mail.gmail.com>
<CA+U5nML64Y7Nf0mpQirk-tOWrV+ZQ3y8DdRgk2mP+e3kGT16Mw@mail.gmail.com>
<CAFcNs+rAJO6wvzN8zQCTUpii0mC9Ax51JxVhWTsos7xsFdwXjw@mail.gmail.com>
<CA+TgmoaCL4G+YotjjjFM+J_h0nSkp4gXiiBPDQGHxTcc_T0w-w@mail.gmail.com>
<CAFcNs+r-GyizHAPDvRz=3XR3BYLUqxpqxrvJq8spk4PJe5hxAA@mail.gmail.com>
<52A59D10.7020209@lab.ntt.co.jp>
<CAFj8pRA_9SssJuictTLwoc0EGNEoYADZ1dCVW9UV4TKwi=4Zzw@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
(2013/12/09 19:35), Pavel Stehule wrote:
>
>
>
> 2013/12/9 KONDO Mitsumasa <kondo.mitsumasa@lab.ntt.co.jp
> <mailto:kondo.mitsumasa@lab.ntt.co.jp>>
>
> Hi FabrÃzio,
>
> I test your v4 patch, and send your review comments.
>
> * Fix typo
> > 49 -# commited transactions from the master, specify a recovery time delay.
> > 49 +# committed transactions from the master, specify a recovery time delay.
>
> * Fix white space
> > 177 - if (secs <= 0 && microsecs <=0)
> > 177 + if (secs <= 0 && microsecs <=0 )
>
> * Add functionality (I propose)
> We can set negative number at min_standby_apply_delay. I think that this feature
> is for world wide replication situation. For example, master server is in
> Japan and slave server is in San Francisco. Japan time fowards than San
> Francisco time
> . And if we want to delay in this situation, it can need negative number in
> min_standby_apply_delay. So I propose that time delay conditional branch
> change under following.
> > - if (min_standby_apply_delay > 0)
> > + if (min_standby_apply_delay != 0)
> What do you think? It might also be working collectry.
>
>
> what using interval instead absolute time?
This is because local time is recorded in XLOG. And it has big cost for
calculating global time.
Regards,
--
Mitsumasa KONDO
NTT Open Source Software Center
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: kondo.mitsumasa@lab.ntt.co.jp, pavel.stehule@gmail.com, fabriziomello@gmail.com, robertmhaas@gmail.com, simon@2ndquadrant.com
Subject: Re: Time-Delayed Standbys
In-Reply-To: <52A5A17D.5010504@lab.ntt.co.jp>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox