pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Yotsunaga, Naoki <yotsunaga.naoki@jp.fujitsu.com>
Cc: Postgres hackers <pgsql-hackers@postgresql.org>
Subject: Re: automatic restore point
Date: Wed, 10 Oct 2018 23:09:23 +0200
Message-ID: <52f37192-099b-ae8f-40b9-c880d2cf9f41@2ndquadrant.com> (raw)
In-Reply-To: <4566041d-2567-74d2-d135-19ff6a20fe51@2ndquadrant.com>
References: <20181001220632.7a4jnzph2cwntq6w@alvherre.pgsql>
	<4566041d-2567-74d2-d135-19ff6a20fe51@2ndquadrant.com>

On 05/10/2018 15:26, Peter Eisentraut wrote:
> It looked for a moment that
> 
>     isCompleteQuery = (context <= PROCESS_UTILITY_QUERY)
> 
> in ProcessUtilitySlow() might be a problem, since that omits
> PROCESS_UTILITY_QUERY_NONATOMIC, but it's not actually a problem, since
> the commands that run this way (CALL and SET from PL/pgSQL) don't have
> event triggers.  But anyway, I propose the attached patch to rephrase
> that.  Also some tests that show it all works as expected.

I have committed these to master.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services




view thread (30+ messages)

Message-ID: <52f37192-099b-ae8f-40b9-c880d2cf9f41@2ndquadrant.com>
Permalink:  ../52f37192-099b-ae8f-40b9-c880d2cf9f41@2ndquadrant.com/
Also on:    postgresql.org/message-id/52f37192-099b-ae8f-40b9-c880d2cf9f41@2ndquadrant.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: peter.eisentraut@2ndquadrant.com, alvherre@2ndquadrant.com, michael@paquier.xyz, yotsunaga.naoki@jp.fujitsu.com
  Subject: Re: automatic restore point
  In-Reply-To: <52f37192-099b-ae8f-40b9-c880d2cf9f41@2ndquadrant.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox