pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Petr Jelinek <petr@2ndquadrant.com>
To: Andres Freund <andres@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Antonin Houska <antonin.houska@gmail.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: bgworker crashed or not?
Date: Wed, 16 Apr 2014 15:35:01 +0200
Message-ID: <534E8705.5040500@2ndquadrant.com> (raw)
In-Reply-To: <20140416131052.GG17874@awork2.anarazel.de>
References: <52EBE0E0.8040303@gmail.com>
	<CA+TgmoY-ra-4ScB5=pnZmqi19OadzzM=GDKn_qvm1D+6mJ15zA@mail.gmail.com>
	<30853.1391440857@sss.pgh.pa.us>
	<CA+Tgmoa047dAbaEToo6QUUTMhwi4QN+EnaM+DXgW7O-9zjm=0Q@mail.gmail.com>
	<32224.1391444962@sss.pgh.pa.us>
	<20140416131052.GG17874@awork2.anarazel.de>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>

On 16/04/14 15:10, Andres Freund wrote:
>
> I think we really should bite the bullet and change this before 9.4
> comes out. The current static bgworker facility has only been out there
> for one release, and dynamic bgworkers aren't released yet at all. If we
> wait with this for 9.5, we'll annoy many more people.
>

+1


> On 2014-02-03 11:29:22 -0500, Tom Lane wrote:
>> Robert Haas <robertmhaas@gmail.com> writes:
>>> On Mon, Feb 3, 2014 at 10:20 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>>>> So
>>>> exit(0) - done, permanently
>>>> exit(1) - done until restart interval
>>>> exit(other) - crash
>>>> and there's no way to obtain the "restart immediately" behavior?
>>

Also I think if we do it this way, the incompatibility impact is rather 
small for most existing bgworkers, like Robert I haven't seen anybody 
actually using the exit code 0 currently - I am sure somebody does, but 
it seems to be very small minority.

-- 
  Petr Jelinek                  http://www.2ndQuadrant.com/
  PostgreSQL Development, 24x7 Support, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



view thread (36+ messages)  latest in thread

Message-ID: <534E8705.5040500@2ndquadrant.com>
Permalink:  ../534E8705.5040500@2ndquadrant.com/
Also on:    postgresql.org/message-id/534E8705.5040500@2ndquadrant.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: petr@2ndquadrant.com, andres@2ndquadrant.com, tgl@sss.pgh.pa.us, robertmhaas@gmail.com, antonin.houska@gmail.com
  Subject: Re: bgworker crashed or not?
  In-Reply-To: <534E8705.5040500@2ndquadrant.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox