pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>
To: Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>
Cc: Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>
Cc: Shigeru Hanada <shigeru.hanada@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: inherit support for foreign tables
Date: Tue, 01 Jul 2014 15:55:40 +0900
Message-ID: <53B25B6C.7020504@lab.ntt.co.jp> (raw)
In-Reply-To: <CAFjFpRdkF4_Lxui5mnTKDySU3kfWY58BToa8ZVa91-7OssYK1w@mail.gmail.com>
References: <53393E18.3080901@lab.ntt.co.jp>
	<533C01C7.6030809@lab.ntt.co.jp>
	<53706FB6.6000403@lab.ntt.co.jp>
	<20140620.170406.123403564.horiguchi.kyotaro@lab.ntt.co.jp>
	<CAFjFpRcG03b3UZSXTKmro+72qYTdBfxoWCaEMgZBxY1QKyJrbQ@mail.gmail.com>
	<53A92924.90702@lab.ntt.co.jp>
	<53B10914.2010504@lab.ntt.co.jp>
	<CAFjFpRcFdb1Xr5FkBjxWudnV0DuLr6i3Ue-wcNhU8d0h9=E2ag@mail.gmail.com>
	<53B1405F.7040203@lab.ntt.co.jp>
	<CAFjFpRdmwNEZxDPx_hBXmO3kG0gAQPnPSp6MBYXPMY+tyfDCKQ@mail.gmail.com>
	<53B21861.1000706@lab.ntt.co.jp>
	<CAFjFpRdkF4_Lxui5mnTKDySU3kfWY58BToa8ZVa91-7OssYK1w@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>

(2014/07/01 15:13), Ashutosh Bapat wrote:
> On Tue, Jul 1, 2014 at 7:39 AM, Etsuro Fujita
> <fujita.etsuro@lab.ntt.co.jp <mailto:fujita.etsuro@lab.ntt.co.jp>> wrote:

> We may want to modify use_physical_tlist(), to return false, in case of
> foreign tables. BTW, it does return false for inheritance trees.

Yeah, but please consider cases where foreign tables are not inheritance 
child rels (and any system columns are requested).

>   486     /*
>   487      * Can't do it with inheritance cases either (mainly because
> Append
>   488      * doesn't project).
>   489      */
>   490     if (rel->reloptkind != RELOPT_BASEREL)
>   491         return false;
>
>     Yeah, we can call build_physical_tlist() (and do that in some
>     cases), but if we call the function, it would generate a tlist that
>     contains all Vars in the relation, not only those Vars actually
>     needed by the query (ie, Vars in reltargetlist), and thus it would
>     take more cycles to compute attr_used from the tlist than from
>     reltargetlist.  That' what I wanted to say.

Maybe I'm missing something, but what's the point of using the tlist, 
not reltargetlist?

Thanks,

Best regards,
Etsuro Fujita


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



view thread (179+ messages)  latest in thread

Message-ID: <53B25B6C.7020504@lab.ntt.co.jp>
Permalink:  ../53B25B6C.7020504@lab.ntt.co.jp/
Also on:    postgresql.org/message-id/53B25B6C.7020504@lab.ntt.co.jp

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: fujita.etsuro@lab.ntt.co.jp, ashutosh.bapat@enterprisedb.com, horiguchi.kyotaro@lab.ntt.co.jp, shigeru.hanada@gmail.com
  Subject: Re: inherit support for foreign tables
  In-Reply-To: <53B25B6C.7020504@lab.ntt.co.jp>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox