public inbox for [email protected]
help / color / mirror / Atom feedFrom: Peter Eisentraut <[email protected]>
To: Jacob Champion <[email protected]>
To: [email protected] <[email protected]>
Subject: Re: automatically generating node support functions
Date: Tue, 7 Sep 2021 10:57:02 +0200
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
<[email protected]>
<[email protected]>
<[email protected]>
On 02.09.21 20:53, Jacob Champion wrote:
>> 0004-Make-node-output-prefix-match-node-structure-name.patch
>>
>> Some nodes' output/read functions use a label that is slightly different
>> from their node name, e.g., "NOTIFY" instead of "NOTIFYSTMT". This
>> cleans that up so that an automated approach doesn't have to deal with
>> these special cases.
>
> Is there any concern about the added serialization length, or is that
> trivial in practice? The one that particularly caught my eye is
> RANGETBLENTRY, which was previously RTE. But I'm not very well-versed
> in all the places these strings can be generated and stored.
These are just matters of taste. Let's wait a bit more to see if anyone
is concerned.
>> 0005-Add-Cardinality-typedef.patch
>>
>> Adds a typedef Cardinality for double fields that store an estimated row
>> or other count. Works alongside Cost and Selectivity.
>
> Should RangeTblEntry.enrtuples also be a Cardinality?
Yes, I'll add that.
view thread (77+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: automatically generating node support functions
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox