From: Heikki Linnakangas <hlinnakangas@vmware.com>
To: Emre Hasegeli <emre@hasegeli.com>
To: Alexander Korotkov <aekorotkov@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: KNN-GiST with recheck
Date: Mon, 15 Dec 2014 17:16:21 +0200
Message-ID: <548EFB45.1000705@vmware.com> (raw)
In-Reply-To: <20140803134809.GA58181@hasegeli-2.local>
References: <20140803134809.GA58181@hasegeli-2.local>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
On 08/03/2014 04:48 PM, Emre Hasegeli wrote:
>>> 1. This patch introduces a new "polygon <-> point" operator. That seems
>>> useful on its own, with or without this patch.
>>
>> Yeah, but exact-knn cant come with no one implementation. But it would
>> better come in a separate patch.
>
> I tried to split them. Separated patches are attached. I changed
> the order of the arguments as point <-> polygon, because point was
> the first one on all the others. Its commutator was required for
> the index, so I added it on the second patch. I also added tests
> for the operator. I think it is ready for committer as a separate
> patch. We can add it to the open CommitFest.
Ok, committed this part now with minor changes. The implementation was
copy-pasted from circle <-> polygon, so I put the common logic to a
dist_ppoly_internal function, and called that in both dist_cpoly and
dist_ppoly.
I was surprised that there were no documentation changes in the patch,
but looking at the docs, we just list the geometric operators without
explaining what the argument types are. That's not very comprehensive,
might be good to expand the docs on that, but it's not this patch's fault.
- Heikki
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: hlinnakangas@vmware.com, emre@hasegeli.com, aekorotkov@gmail.com
Subject: Re: KNN-GiST with recheck
In-Reply-To: <548EFB45.1000705@vmware.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox