From: Joshua D. Drake <jd@commandprompt.com>
To: Bruce Momjian <bruce@momjian.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: tablespaces inside $PGDATA considered harmful
Date: Fri, 30 Jan 2015 08:43:23 -0800
Message-ID: <54CBB4AB.1090805@commandprompt.com> (raw)
In-Reply-To: <20150130161928.GB20744@momjian.us>
References: <CA+TgmobZLyLU8tFCbMqbjMWB6t+=ERaDo820uQEJCVAQK_Paow@mail.gmail.com>
<20150130161928.GB20744@momjian.us>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
On 01/30/2015 08:19 AM, Bruce Momjian wrote:
>
> On Fri, Jan 30, 2015 at 11:12:43AM -0500, Robert Haas wrote:
>> I think everyone who has read this mailing list for a while is
>> probably already aware of this problem. When you create a tablespace
>> somewhere inside the data directory, weird things happen. If you
>> pg_upgrade and then incautiously run the delete_old_cluster.sh script
>> thus created, you will blow away large chunks of your data.[1] If you
>
> pg_upgrade doesn't create the deletion script in this case, and warns
> the user:
>
> Could not create a script to delete the old cluster's data
> files because user-defined tablespaces exist in the old cluster
> directory. The old cluster's contents must be deleted manually.
>
>> In the short term, I favor just adding a warning, so that people get
>> some clue that they are doing something that might be a bad idea. In
>> the long term, we might want to do more. Thoughts?
>
> Yes, good idea.
Uhm, wouldn't it be a rather simple patch to say:
if tablespace_create() in $PGDATA:
ERROR!
?
I mean yes a warning is good but it is after the fact, the tablespace is
already created. We know that tablespaces in $PGDATA are a bad idea, why
not protect the user?
JD
>
--
Command Prompt, Inc. - http://www.commandprompt.com/ 503-667-4564
PostgreSQL Support, Training, Professional Services and Development
High Availability, Oracle Conversion, @cmdpromptinc
"If we send our children to Caesar for their education, we should
not be surprised when they come back as Romans."
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: jd@commandprompt.com, bruce@momjian.us, robertmhaas@gmail.com
Subject: Re: tablespaces inside $PGDATA considered harmful
In-Reply-To: <54CBB4AB.1090805@commandprompt.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox