public inbox for [email protected]  

help / color / mirror / Atom feed

From: Peter Eisentraut <[email protected]>
To: Nathan Bossart <[email protected]>
Cc: pgsql-hackers <[email protected]>
Subject: Re: Refactor recordExtObjInitPriv()
Date: Thu, 12 Jan 2023 18:15:14 +0100
Message-ID: <[email protected]> (raw)
In-Reply-To: <20230112000437.GA2032194@nathanxps13>
References: <[email protected]>
	<20230112000437.GA2032194@nathanxps13>

On 12.01.23 01:04, Nathan Bossart wrote:
>> -			 classoid == AggregateRelationId ||
> I noticed that AggregateRelationId isn't listed in the ObjectProperty
> array, so I think recordExtObjInitPriv() will begin erroring for that
> classoid instead of ignoring it like we do today.

Hmm, we do have some extensions in contrib that add aggregates (citext, 
intagg).  I suspect that the aggregate function is actually registered 
into the extension via its pg_proc entry, so this wouldn't actually 
matter.  But maybe the commenting should be clearer?

view thread (4+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: Refactor recordExtObjInitPriv()
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox