pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Andreas Karlsson <andreas@proxel.se>
To: Julien Tachoires <julmon@gmail.com>
To: Alex Shulgin <ash@commandprompt.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Jaime Casanova <jaime@2ndquadrant.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: patch : Allow toast tables to be moved to a different tablespace
Date: Sat, 14 Mar 2015 16:05:52 +0100
Message-ID: <55044E50.20401@proxel.se> (raw)
In-Reply-To: <5502C06E.5010300@gmail.com>
References: <4E8F1666.2060409@gmail.com>
	<CAJKUy5ix3xb8E_+hLfPvz_n+oYTU36-aMfOVNpC5=4PAf-o_jg@mail.gmail.com>
	<CAFEQCbGPrRpV1+bQSQ-v0i-md18rvx6jpyR=TEYt+9sPCfTMYw@mail.gmail.com>
	<CAJKUy5iMp-NE=24WSNQt5Npp0SLkPTDkqVz9C8D9y=pdK=eFoQ@mail.gmail.com>
	<CAFEQCbH756DyyAPQ1ykh3+b+kE1-EhWRww1WO_x5v38C-uLnUg@mail.gmail.com>
	<CAJKUy5itRAtv7A3y7nVKmKe8SZdTU5Q-OsPr4d3ySYqoHkzK1g@mail.gmail.com>
	<CAFEQCbGmVoeSVyeh8ZCJKpN+NKH2rgvZq1rMrKjZ+YE7RpM8zw@mail.gmail.com>
	<CAJKUy5gYJPR0ETVQQvSf2-mDfdsJU-7XSUVDFN_o4+ZaZtyATg@mail.gmail.com>
	<CAFEQCbGEjp6j6-XD4C-vDaAyRHh6aMbH__BWB3kBuT505LXQyw@mail.gmail.com>
	<CA+TgmoaJOK6yKMZw8sc5HzRD8hb0bzCV0U4JuNc3XdACmfQCYw@mail.gmail.com>
	<CAFEQCbESRGXLE4+tRAnazr8QmBJzfYPwc6GP1Daq0quyuyEpZQ@mail.gmail.com>
	<1323956011-sup-9589@alvh.no-ip.org>
	<CAFEQCbEq07OopgE5xFYv2Q3eMq45hRSJkjCBO+kvpJq9NEVhow@mail.gmail.com>
	<87r3wn5lhq.fsf@commandprompt.com>
	<54A2127D.5020907@proxel.se>
	<54F5CFDE.20301@gmail.com>
	<54FE2D6B.8000205@proxel.se>
	<5502C06E.5010300@gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>

On 03/13/2015 11:48 AM, Julien Tachoires wrote:
> Here is a new version rebased against head and considering Andreas' last
> comments:
>
>    - New regression tests about the fact that a notice is raised when
> ALTER TABLE SET TOAST TABLESPACE is done for a non-TOASTed table.
>    - New regression tests to check that a TOAST index follows the TOAST
> table when it's moved.
>    - Some fixes in the documentation.
>    - psql's '\d' command shows now both table and TOAST table tablespaces
> when they are different, even if one of them is pg_default.
>    - patch added to the next open commitfest:
> https://commitfest.postgresql.org/5/188/

Nice, I have no remaining comments on this patch other than some 
incorrect mixing of whitespace in the indentation of the "Case when 
TOAST and table tablespaces are different and als" comment.

Once that has been fixed I would say this patch is technically ready for 
committer, but since it is in the open commitfest I do not think it will 
get committed any time soon.

-- 
Andreas Karlsson


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



view thread (56+ messages)  latest in thread

Message-ID: <55044E50.20401@proxel.se>
Permalink:  ../55044E50.20401@proxel.se/
Also on:    postgresql.org/message-id/55044E50.20401@proxel.se

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: andreas@proxel.se, julmon@gmail.com, ash@commandprompt.com, alvherre@2ndquadrant.com, jaime@2ndquadrant.com, robertmhaas@gmail.com
  Subject: Re: patch : Allow toast tables to be moved to a different tablespace
  In-Reply-To: <55044E50.20401@proxel.se>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox