pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Eisentraut <peter_e@gmx.net>
To: Michael Paquier <michael.paquier@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Cc: Fabien COELHO <coelho@cri.ensmp.fr>
Subject: Re: improving speed of make check-world
Date: Fri, 10 Apr 2015 15:35:28 -0400
Message-ID: <55282600.9030804@gmx.net> (raw)
In-Reply-To: <CAB7nPqSAYcJ-OTVrNBnhPQJzGbZ1JcUUgv8WAm3Ng=kU=1f2fg@mail.gmail.com>
References: <53ED9E6C.1080700@gmx.net>
	<alpine.DEB.2.10.1408311125080.14824@sto>
	<54DFFE0C.4060100@gmx.net>
	<CAB7nPqTgR+-NB3UhOebpicY9oJpDrECMWXiuTBPNM2wecq+Osg@mail.gmail.com>
	<54FC4D2D.8060901@gmx.net>
	<CAB7nPqRBrp=cc5caK3dNCpxu8CrY1SdZ+VXk0VAFj_xqi_mdYg@mail.gmail.com>
	<CAB7nPqSAYcJ-OTVrNBnhPQJzGbZ1JcUUgv8WAm3Ng=kU=1f2fg@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>

On 3/9/15 2:51 AM, Michael Paquier wrote:
> On Sun, Mar 8, 2015 at 10:46 PM, Michael Paquier
> <michael.paquier@gmail.com> wrote:
>> Speaking of which, attached is a patch rewritten in-line with those
>> comments, simplifying a bit the whole at the same time. Note this
>> patch changes ecpgcheck as it should be patched, but as ecpgcheck test
>> is broken even on HEAD, I'll raise a separate thread about that with a
>> proper fix (for example bowerbird skips this test).
> 
> Correction: HEAD is fine, but previous patch was broken because it
> tried to use --top-builddir. Also for ecpgcheck it looks that tricking
> PATH is needed to avoid dll loading errors related to libecpg.dll and
> libecpg_compat.dll. Updated patch is attached.

To clarify: Are you of the opinion that your patch (on top of my base
patch) is sufficient to make all of this work on Windows?



-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



view thread (22+ messages)  latest in thread

Message-ID: <55282600.9030804@gmx.net>
Permalink:  ../55282600.9030804@gmx.net/
Also on:    postgresql.org/message-id/55282600.9030804@gmx.net

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: peter_e@gmx.net, michael.paquier@gmail.com, coelho@cri.ensmp.fr
  Subject: Re: improving speed of make check-world
  In-Reply-To: <55282600.9030804@gmx.net>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox