pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Heikki Linnakangas <hlinnaka@iki.fi>
To: Alexander Korotkov <aekorotkov@gmail.com>
To: Tomas Vondra <tomas.vondra@2ndquadrant.com>
To: Heikki Linnakangas <hlinnakangas@vmware.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: KNN-GiST with recheck
Date: Wed, 13 May 2015 22:16:15 +0300
Message-ID: <5553A2FF.1030501@iki.fi> (raw)
In-Reply-To: <CAPpHfdv40pmc7N3CcpBDEcTAnLT6dWaN76LP5Q9xzTvvdwRMQg@mail.gmail.com>
References: <CAPpHfdvn5jxgh-rVMz7c2vXoYW_W7dGrJjQkVAtaCr=-ZMCADA@mail.gmail.com>
	<20140803134809.GA58181@hasegeli-2.local>
	<CAPpHfdu3JmBrsgsrtaAQJMpXyMgrW+T2P7Gmf9oP8L1V7zLvOg@mail.gmail.com>
	<20140914180936.GA5084@hasegeli.com>
	<CAPpHfdvEpZAJrMBkNrCguG4fCK5QtZjARPti7LnL5chsSuD=Sg@mail.gmail.com>
	<20140926011800.GA8130@momjian.us>
	<CAPpHfdvDMS1_jqnzZ0FbGePWwCvStj4_h0xU2hYTnLcC6of3Rg@mail.gmail.com>
	<20140929021631.GG12447@momjian.us>
	<CAPpHfdvdL0dtoNBmbCsJ=W0bFE7A87hLOtoBN7Pe4hnXkQ9LxA@mail.gmail.com>
	<20141006093609.GA12899@hasegeli.com>
	<5490357C.8090800@vmware.com>
	<CAPpHfdtm=A3hrw4=mhNxN6U2Q9bx4BYDhW8gRLxgaZD3MAQKCA@mail.gmail.com>
	<CAPpHfdstkF4RW_1cYje=EZyTx5VRgUK_+L3c2ucBASdD156tVg@mail.gmail.com>
	<CAPpHfduGjVpTLVxwXmeMuFqR-ykH-ERdewF-KHxSQiRdw29-7g@mail.gmail.com>
	<54EC8D3E.2000908@2ndquadrant.com>
	<CAPpHfdsZVJnMMOuTUusJQmcR1QeRN4qc93-KE014_JHqYU717g@mail.gmail.com>
	<CAPpHfdv40pmc7N3CcpBDEcTAnLT6dWaN76LP5Q9xzTvvdwRMQg@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>

On 04/17/2015 12:05 PM, Alexander Korotkov wrote:
> On Wed, Feb 25, 2015 at 12:15 PM, Alexander Korotkov <aekorotkov@gmail.com>
> wrote:
>
>> Hi!
>>
>> On Tue, Feb 24, 2015 at 5:39 PM, Tomas Vondra <
>> tomas.vondra@2ndquadrant.com> wrote:
>>
>>> On 17.2.2015 14:21, Alexander Korotkov wrote:
>>>> On Sun, Feb 15, 2015 at 2:08 PM, Alexander Korotkov
>>>> <aekorotkov@gmail.com <mailto:aekorotkov@gmail.com>> wrote:
>>>>
>>>> Revised patch with reordering in GiST is attached
>>>> (knn-gist-recheck-in-gist.patch) as well as testing script (test.py).
>>>
>>> I meant to do a bit of testing on this (assuming it's still needed), but
>>> the patches need rebasing - Heikki fixed a few issues, so they don't
>>> apply cleanly.
>>>
>>
>> Both patches are revised.
>>
>
> Both patches are rebased against current master.

This looks pretty much ready. I'm going to spend some time on this on 
Friday, and if all looks good, commit. (Thursday's a public holiday here).

One quick comment:

It would be good to avoid the extra comparisons of the distances, when 
the index doesn't return any lossy items. As the patch stands, it adds 
one extra copyDistances() call and a cmp_distances() call for each tuple 
(in a knn-search), even if there are no lossy tuples.

- Heikki



-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



view thread (42+ messages)  latest in thread

Message-ID: <5553A2FF.1030501@iki.fi>
Permalink:  ../5553A2FF.1030501@iki.fi/
Also on:    postgresql.org/message-id/5553A2FF.1030501@iki.fi

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: hlinnaka@iki.fi, aekorotkov@gmail.com, tomas.vondra@2ndquadrant.com, hlinnakangas@vmware.com
  Subject: Re: KNN-GiST with recheck
  In-Reply-To: <5553A2FF.1030501@iki.fi>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox