From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrei Lepikhov <lepihov@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: Add Postgres module info
Date: Wed, 11 Dec 2024 20:36:11 -0500
Message-ID: <556341.1733967371@sss.pgh.pa.us> (raw)
In-Reply-To: <2c215c98-f713-4c5b-b21a-a4b8fa41890b@gmail.com>
References: <dd4d1b59-d0fe-49d5-b28f-1e463b68fa32@gmail.com>
<506788.1733941263@sss.pgh.pa.us>
<2c215c98-f713-4c5b-b21a-a4b8fa41890b@gmail.com>
Andrei Lepikhov <lepihov@gmail.com> writes:
> It makes sense. But I want to clarify that I avoided changing
> PG_MODULE_MAGIC because the newly introduced structure has a totally
> different purpose and usage logic: the struct is designed to check
> compatibility, but module info isn't connected to the core version at
> all: a single version of the code may be built for multiple PG versions.
> At the same time, various versions of the same library may be usable
> with the same core.
Surely. But I don't see a need for two separately-looked-up
physical structures. Seems to me it's sufficient to put the
ABI-checking fields into a sub-struct within the magic block.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, lepihov@gmail.com
Subject: Re: Add Postgres module info
In-Reply-To: <556341.1733967371@sss.pgh.pa.us>
References: <dd4d1b59-d0fe-49d5-b28f-1e463b68fa32@gmail.com> <506788.1733941263@sss.pgh.pa.us> <2c215c98-f713-4c5b-b21a-a4b8fa41890b@gmail.com> <556341.1733967371@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox