From: Petr Jelinek <petr@2ndquadrant.com>
To: Peter Eisentraut <peter_e@gmx.net>
To: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: pg_resetsysid
Date: Sat, 18 Jul 2015 15:42:38 +0200
Message-ID: <55AA57CE.4020400@2ndquadrant.com> (raw)
In-Reply-To: <55A99E07.3050905@gmx.net>
References: <557D9DED.2080204@2ndquadrant.com>
<55A99E07.3050905@gmx.net>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
On 2015-07-18 02:29, Peter Eisentraut wrote:
> On 6/14/15 11:29 AM, Petr Jelinek wrote:
>> 0002 - Adds pg_resetsysid utility which changes the system id to newly
>> generated one.
>>
>> 0003 - Adds -s option to pg_resetxlog to change the system id to the one
>> specified - this is separate from the other one as it can be potentially
>> more dangerous.
>
> Adding a new top-level binary creates a lot of maintenance overhead
> (e.g., documentation, man page, translations, packaging), and it seems
> silly to create a new tool whose only purpose is to change one number in
> one file. If we're going to have this in pg_resetxlog anyway, why not
> create another option letter to assigns a generated ID? As the
> documentation says, resetting the system ID clears the WAL, so it's not
> like this is a completely danger-free situation.
>
Well, last time I submitted this I did it exactly as you propose but
there was long discussion about this changing the target audience of
pg_resetxlog and that it would be better as separate binary from
pg_resetxlog.
It might more future proof to have more generic binary which can do all
the less dangerous work that pg_resetxlog does (which currently is
probably only -c and the newly proposed -s). Something like
pg_setcontroldata but that's too long.
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: petr@2ndquadrant.com, peter_e@gmx.net
Subject: Re: pg_resetsysid
In-Reply-To: <55AA57CE.4020400@2ndquadrant.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox