agora inbox for pgsql-hackers@postgresql.org  
help / color / mirror / Atom feed
From: Heikki Linnakangas <hlinnaka@iki.fi>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Simon Riggs <simon@2ndquadrant.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andres Freund <andres@anarazel.de>
Cc: Fujii Masao <masao.fujii@gmail.com>
Cc: Martijn van Oosterhout <kleptog@svana.org>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: WAL logging problem in 9.4.3?
Date: Fri, 24 Jul 2015 09:27:13 +0300
Message-ID: <55B1DAC1.3030804@iki.fi> (raw)
In-Reply-To: <CA+TgmobUs0unpdZF=nMhOGGX9EkxBH8ZzpAJi8FBsqrPyyJXOQ@mail.gmail.com>
References: <CAHGQGwFtOMv5h8eKX6zf+9_0UxpcTsyH9xAnyv6KdGH4BonLiw@mail.gmail.com>
	<28320.1435935120@sss.pgh.pa.us>
	<CAHGQGwGzxAyKLUm+z2n43-ee6u976jLmQAz=pPBVzSueD3CAig@mail.gmail.com>
	<20150703164931.GI3291@awork2.anarazel.de>
	<20150703170229.GJ3291@awork2.anarazel.de>
	<20150703172605.GM3291@awork2.anarazel.de>
	<CAHGQGwGGM2OBh4WOTd8wWqxKzRy+WdJX+-fxxPCWNz4eeJ1aQQ@mail.gmail.com>
	<27532.1436195680@sss.pgh.pa.us>
	<20150706152123.GK8902@alap3.anarazel.de>
	<28415.1436197794@sss.pgh.pa.us>
	<20150709182315.GG10242@alap3.anarazel.de>
	<29916.1436483171@sss.pgh.pa.us>
	<CANP8+jKN4V4MJEzFN_iEtdZ+1oM=YETxvmuu1YK4UMXQY2gaGw@mail.gmail.com>
	<55AFC302.1060805@iki.fi>
	<CA+TgmobUs0unpdZF=nMhOGGX9EkxBH8ZzpAJi8FBsqrPyyJXOQ@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>

On 07/23/2015 09:38 PM, Robert Haas wrote:
> On Wed, Jul 22, 2015 at 12:21 PM, Heikki Linnakangas <hlinnaka@iki.fi> wrote:
>>
>> This is more invasive than I'd like to backpatch, but I think it's the
>> simplest approach that works, and doesn't disable any of the important
>> optimizations we have.
>
> Hmm, isn't HeapNeedsWAL() a lot more costly than RelationNeedsWAL()?

Yes. But it's still very cheap, especially in the common case that the 
pending syncs hash table is empty.

> Should we be worried about that?

It doesn't worry me.

- Heikki



-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



view thread (244+ messages)  latest in thread

Message-ID: <55B1DAC1.3030804@iki.fi>
Permalink:  ../55B1DAC1.3030804@iki.fi/
Also on:    postgresql.org/message-id/55B1DAC1.3030804@iki.fi

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: hlinnaka@iki.fi, robertmhaas@gmail.com, simon@2ndquadrant.com, tgl@sss.pgh.pa.us, andres@anarazel.de, masao.fujii@gmail.com, kleptog@svana.org
  Subject: Re: WAL logging problem in 9.4.3?
  In-Reply-To: <55B1DAC1.3030804@iki.fi>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox