From: Heikki Linnakangas <hlinnaka@iki.fi>
To: Jeff Janes <jeff.janes@gmail.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Cc: Amit Langote <amitlangote09@gmail.com>
Subject: Re: All-zero page in GIN index causes assertion failure
Date: Mon, 27 Jul 2015 18:21:28 +0300
Message-ID: <55B64C78.4030100@iki.fi> (raw)
In-Reply-To: <CAMkU=1w0+whCvz40sW7ptJXQ8S5G_HW_JvDeTyR816JM9+1OOw@mail.gmail.com>
References: <55ACADCD.6020206@iki.fi>
<55AD0266.4050300@iki.fi>
<20150720161124.GR2301@postgresql.org>
<55AD58CD.2000607@iki.fi>
<CAMkU=1w0+whCvz40sW7ptJXQ8S5G_HW_JvDeTyR816JM9+1OOw@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
On 07/23/2015 07:43 PM, Jeff Janes wrote:
> On Mon, Jul 20, 2015 at 1:23 PM, Heikki Linnakangas <hlinnaka@iki.fi> wrote:
>
>> I came up with the attached, for GIN and SP-GiST. Instead of WAL-logging
>> the page initialization in SP-GiST vacuum, I changed it so that it simply
>> leaves the page as all-zeroes, and adds it to the FSM. The code that grabs
>> a target page from the FSM handles that, and initializes the page anyway,
>> so that was simpler. This made the SP-GiST is-deleted flag obsolete, it's
>> no longer set, although the code still checks for it for
>> backwards-compatibility. (even that may actually be unnecessary, as a page
>> that's marked as deleted must also be empty, and wherever we check for the
>> deleted-flag, we also check for PageIsEmpty()))
>
> This patch, in conjunction with the LWLock deadlock patch, fixes all the
> issues I was having with GIN indexes in 9.5.
Thanks, I've pushed this, as well a fix to similar failure from B-tree
vacuum that Amit Langote reported in the other thread.
- Heikki
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: hlinnaka@iki.fi, jeff.janes@gmail.com, alvherre@2ndquadrant.com, amitlangote09@gmail.com
Subject: Re: All-zero page in GIN index causes assertion failure
In-Reply-To: <55B64C78.4030100@iki.fi>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox