From: Petr Jelinek <petr@2ndquadrant.com>
To: Fujii Masao <masao.fujii@gmail.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: pgsql-docs <pgsql-docs@postgresql.org>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Cc: Craig Ringer <craig@2ndquadrant.com>
Subject: Re: [DOCS] max_worker_processes on the standby
Date: Wed, 16 Sep 2015 05:12:34 +0200
Message-ID: <55F8DE22.5090602@2ndquadrant.com> (raw)
In-Reply-To: <CAHGQGwE5gw63zY8+jfaF++AKxk8nS21eHREjCCYOB=sdJLROwQ@mail.gmail.com>
References: <CAHGQGwE5gw63zY8+jfaF++AKxk8nS21eHREjCCYOB=sdJLROwQ@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
On 2015-09-03 15:03, Fujii Masao wrote:
> On Sat, Aug 8, 2015 at 11:02 PM, Robert Haas <robertmhaas@gmail.com> wrote:
>> There's no existing precedent for a feature that lets the standby be
>> different from the master *in any way*. So I don't see why we should
>> start here. I think the reasonable definition is that the GUC
>> controls whether the master tries to update the SLRU (and generate
>> appropriate WAL records, presumably). The standby should not get a
>> choice about whether to replay those WAL records.
>
> +1
>
> I added this to the 9.5 open item list.
>
I see I forgot to send patch for this, so here it is. It just removes
the on start check for track_commit_timestamp being same in config and
control file.
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackersAttachments:committs-standby-fix.patch (application/x-patch, 1.5K) download
From 49533f556d8120564ed81dc67acfcc03d2894166 Mon Sep 17 00:00:00 2001
From: Petr Jelinek <pjmodos@pjmodos.net>
Date: Wed, 16 Sep 2015 04:29:29 +0200
Subject: [PATCH] committs-standby-fix
---
src/backend/access/transam/xlog.c | 16 ----------------
1 file changed, 16 deletions(-)
diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.cindex a092aad..fc5a1d7 100644--- a/src/backend/access/transam/xlog.c+++ b/src/backend/access/transam/xlog.c@@ -5826,19 +5826,6 @@ do { \
minValue))); \
} while(0)
-#define RecoveryRequiresBoolParameter(param_name, currValue, masterValue) \-do { \- bool _currValue = (currValue); \- bool _masterValue = (masterValue); \- if (_currValue != _masterValue) \- ereport(ERROR, \- (errcode(ERRCODE_INVALID_PARAMETER_VALUE), \- errmsg("hot standby is not possible because it requires \"%s\" to be same on master and standby (master has \"%s\", standby has \"%s\")", \- param_name, \- _masterValue ? "true" : "false", \- _currValue ? "true" : "false"))); \-} while(0)-
/*
* Check to see if required parameters are set high enough on this server
* for various aspects of recovery operation.
@@ -5885,9 +5872,6 @@ CheckRequiredParameterValues(void)
RecoveryRequiresIntParameter("max_locks_per_transaction",
max_locks_per_xact,
ControlFile->max_locks_per_xact);
- RecoveryRequiresBoolParameter("track_commit_timestamp",- track_commit_timestamp,- ControlFile->track_commit_timestamp);
}
}
--
1.9.1
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: petr@2ndquadrant.com, masao.fujii@gmail.com, robertmhaas@gmail.com, alvherre@2ndquadrant.com, pgsql-docs@postgresql.org, craig@2ndquadrant.com
Subject: Re: [DOCS] max_worker_processes on the standby
In-Reply-To: <55F8DE22.5090602@2ndquadrant.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox