pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Anastasia Lubennikova <a.lubennikova@postgrespro.ru>
To: pgsql-hackers@postgresql.org
Subject: Re: WIP: Covering + unique indexes.
Date: Wed, 13 Jan 2016 15:56:49 +0300
Message-ID: <56964991.8020705@postgrespro.ru> (raw)
In-Reply-To: <CAKJS1f8LDmtPuYmn5jigsPAqPcGD0EwxkVB-HG5-Nsw-vJhbUg@mail.gmail.com>
References: <56167F09.3090101@postgrespro.ru>
	<56168952.4010101@postgrespro.ru>
	<CAA-aLv7mWdu5WCrUH0sw79abDsq4tdZEpkvV8SfgNyLp92+z6Q@mail.gmail.com>
	<5617DAA3.6080408@postgrespro.ru>
	<565D9859.3040405@postgrespro.ru>
	<CAKJS1f_oR+P_c+u8PtdEFyWPi4NP-vt69sQGYXTv9NQ48U5JiA@mail.gmail.com>
	<CAKJS1f_GYoJsYLJyK_92_v38x8LO5Nk+4w8=E2yqLDbTyPS7ug@mail.gmail.com>
	<CAMkU=1wZ8-mNHNMuG3BeMJkXxPyRJFNqbNnc8CaXMGxpciv8aQ@mail.gmail.com>
	<CAKJS1f9W0aB-g7H6yYgNBq7hJsOKF3UwHU7-Q5jobbaTyK9f4g@mail.gmail.com>
	<569530FC.2010900@postgrespro.ru>
	<CAMkU=1yTjAK3yCdSoVF1uf3gdvvi3qGnt691g9G0BVhwANCixw@mail.gmail.com>
	<CAKJS1f8LDmtPuYmn5jigsPAqPcGD0EwxkVB-HG5-Nsw-vJhbUg@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>



13.01.2016 04:47, David Rowley :
> On 13 January 2016 at 06:47, Jeff Janes <jeff.janes@gmail.com 
> <mailto:jeff.janes@gmail.com>> wrote:
>
>
>     Why is omit_opclass a separate patch?  If the included columns now
>     never participate in the index ordering, shouldn't it be an inherent
>     property of the main patch that you can "cover" things without btree
>     opclasses?
>
>
> I don't personally think the covering_unique_4.0.patch is that close 
> to being too big to review, I think things would make more sense of 
> the omit_opclass_4.0.patch was included together with this.
>

I agree that these patches should be merged. It'll be fixed it the next 
updates.
I kept them separate only for historical reasons, it was more convenient 
for me to debug them. Furthermore, I wanted to show some performance 
degradation caused by "omit_opclass" and give a way to reproduce it 
performing test with and whithot the patch.

-- 
Anastasia Lubennikova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

view thread (217+ messages)  latest in thread

Message-ID: <56964991.8020705@postgrespro.ru>
Permalink:  ../56964991.8020705@postgrespro.ru/
Also on:    postgresql.org/message-id/56964991.8020705@postgrespro.ru

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: a.lubennikova@postgrespro.ru
  Subject: Re: WIP: Covering + unique indexes.
  In-Reply-To: <56964991.8020705@postgrespro.ru>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox