From: David Steele <david@pgmasters.net>
To: Robbie Harwood <rharwood@redhat.com>
To: pgsql-hackers@postgresql.org
Subject: Re: [PATCH v5] GSSAPI encryption support
Date: Fri, 19 Feb 2016 09:24:17 -0500
Message-ID: <56C72591.6000805@pgmasters.net> (raw)
In-Reply-To: <jlgtwl9g95m.fsf@thriss.redhat.com>
References: <jlg1tgq1ktm.fsf@thriss.redhat.com>
<jlg4mdg8ebw.fsf@thriss.redhat.com>
<56BE0FF9.70302@pgmasters.net>
<jlgtwl9g95m.fsf@thriss.redhat.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
On 2/15/16 12:45 PM, Robbie Harwood wrote:
> David Steele <david@pgmasters.net> writes:
>
>> 1) It didn't apply cleanly to HEAD. It did apply cleanly on a455878
>> which I figured was recent enough for testing. I didn't bisect to find
>> the exact commit that broke it.
>
> It applied to head of master (57c932475504d63d8f8a68fc6925d7decabc378a)
> for me (`patch -p1 < v4-GSSAPI-encryption-support.patch`). I rebased it
> anyway and cut a v5 anyway, just to be sure. It's attached, and
> available on github as well:
> https://github.com/frozencemetery/postgres/commit/dc10e3519f0f6c67f79abd157dc8ff1a1c293f53
It could have been my mistake. I'll give it another try when you have a
new patch.
>> 2) While I was able to apply the patch and get it compiled it seemed
>> pretty flaky - I was only able to logon about 1 in 10 times on average.
>> Here was my testing methodology:
>
> What I can't tell from looking at your methodology is whether both the
> client and server were running my patches or no. There's no fallback
> here (I'd like to talk about how that should work, with example from
> v1-v3, if people have ideas). This means that both the client and the
> server need to be running my patches for the moment. Is this your
> setup?
I was testing on a system with no version of PostgreSQL installed. I
applied your patch to master and then ran both server and client from
that patched version. Is there something I'm missing?
--
-David
david@pgmasters.net
Attachments:
signature.asc (application/pgp-signature, 841B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: david@pgmasters.net, rharwood@redhat.com
Subject: Re: [PATCH v5] GSSAPI encryption support
In-Reply-To: <56C72591.6000805@pgmasters.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox