pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andrew Dunstan <andrew@dunslane.net>
To: Matt Wilmas <pgsql_lists@realplain.com>
To: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: btree_gin and btree_gist for enums
Date: Thu, 24 Mar 2016 18:18:00 -0400
Message-ID: <56F46798.60605@dunslane.net> (raw)
In-Reply-To: <95B821E794D949A4B389C6A3F2F7AF16@pc1>
References: <56EA8A71.8060107@dunslane.net>
	<95B821E794D949A4B389C6A3F2F7AF16@pc1>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>



On 03/24/2016 12:40 PM, Matt Wilmas wrote:
>
>
> It would be *really* nice to have this in 9.6.  It seems it's simply 
> filling out functionality that should already be there, right?  An 
> oversight/bug fix so it works "as advertised?" :-)


I think that would be stretching the process a bit far. I'm certainly 
not prepared to commit it unless there is a general consensus to make an 
exception for it.


> Is any other btree type-compatibility missing from these modules?  (I 
> notice the btree_gin docs don't mention "numeric," but it works.)


uuid would be another type that should be fairly easily covered but isn't.


>
>
> I just looked over the patch, and the actual code addition/changes 
> seem pretty small and straightforward (or am I wrong?). 



Yes, sure, it's all fairly simple. Took me a little while to understand 
what I was doing, but once I did it was pretty much plain sailing.

cheers

andrew




-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



view thread (39+ messages)  latest in thread

Message-ID: <56F46798.60605@dunslane.net>
Permalink:  ../56F46798.60605@dunslane.net/
Also on:    postgresql.org/message-id/56F46798.60605@dunslane.net

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: andrew@dunslane.net, pgsql_lists@realplain.com
  Subject: Re: btree_gin and btree_gist for enums
  In-Reply-To: <56F46798.60605@dunslane.net>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox