From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Corey Huinker <corey.huinker@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: some ri_triggers.c cleanup
Date: Mon, 25 Feb 2019 09:33:34 +0100
Message-ID: <56d791ef-d2c7-f64e-3c62-8ebf1efc7cc6@2ndquadrant.com> (raw)
In-Reply-To: <CADkLM=fwEQ+PL9iV3cGoPrUbFkyF0ArhRVoBeOsJ6fXmKt0qSw@mail.gmail.com>
References: <0ccdd3e1-10b0-dd05-d8a7-183507c11eb1@2ndquadrant.com>
<CADkLM=d-epHR_wMG50oBmOPWNvd__bXS=ZSDR2DQAaLURpr7zw@mail.gmail.com>
<CADkLM=fwEQ+PL9iV3cGoPrUbFkyF0ArhRVoBeOsJ6fXmKt0qSw@mail.gmail.com>
On 2019-02-24 00:34, Corey Huinker wrote:
> As I suspected, the code for SET NULL and SET DEFAULT are highly similar
> (see .diff), the major difference being two constants, the order of some
> variable declarations, and the recheck in the set-default case.
>
> The changes were so simple that I felt remiss not adding the patch for
> you (see .patch).
Right, this makes a lot of sense, similar to how ri_restrict() combines
RESTRICT and NO ACTION.
I'll take a closer look at your patch.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: peter.eisentraut@2ndquadrant.com, corey.huinker@gmail.com
Subject: Re: some ri_triggers.c cleanup
In-Reply-To: <56d791ef-d2c7-f64e-3c62-8ebf1efc7cc6@2ndquadrant.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox