pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Thomas Munro <thomas.munro@enterprisedb.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Allowing printf("%m") only where it actually works
Date: Wed, 26 Sep 2018 18:31:07 -0400
Message-ID: <5742.1538001067@sss.pgh.pa.us> (raw)
In-Reply-To: <20180926214952.ol6b6kawc6u3tvu5@alap3.anarazel.de>
References: <14925.1534040609@sss.pgh.pa.us>
	<1437.1534100930@sss.pgh.pa.us>
	<13183.1534624490@sss.pgh.pa.us>
	<30022.1534705920@sss.pgh.pa.us>
	<20180912070739.GK25160@paquier.xyz>
	<1304.1536774001@sss.pgh.pa.us>
	<20180914020256.GD29332@paquier.xyz>
	<13585.1537809527@sss.pgh.pa.us>
	<20180926174645.nsyj77lx2mvtz4kx@alap3.anarazel.de>
	<25501.1537998096@sss.pgh.pa.us>
	<20180926214952.ol6b6kawc6u3tvu5@alap3.anarazel.de>

Andres Freund <andres@anarazel.de> writes:
> On 2018-09-26 17:41:36 -0400, Tom Lane wrote:
>> Well, if you're unhappy about snprintf.c's performance, you could review
>> https://commitfest.postgresql.org/19/1763/
>> so I can push that.  In my tests, that got us down to circa 10% penalty
>> for float conversions.

> Uh, I can do that, but the fact remains that your commit slowed down
> COPY and other conversion intensive workloads by a *significant* amount.

[ shrug... ]  There are other cases that got faster (particularly after
the above-mentioned patch).  I do not wish to consider floating-point
conversion speed as the sole figure of merit for this change.  If we
are to consider only the worst-case, we should be reverting JIT.

			regards, tom lane




view thread (50+ messages)  latest in thread

Message-ID: <5742.1538001067@sss.pgh.pa.us>
Permalink:  ../5742.1538001067@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/5742.1538001067@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, michael@paquier.xyz, thomas.munro@enterprisedb.com, alvherre@2ndquadrant.com, pgsql-hackers@lists.postgresql.org
  Subject: Re: Allowing printf("%m") only where it actually works
  In-Reply-To: <5742.1538001067@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox