pg.ddx.io pgsql-hackers@postgresql.org mailing list archive help / color / mirror / Atom feed From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Dilip Kumar <dilipbalaut@gmail.com>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Cc: David Steele <david@pgmasters.net>
Cc: Ildus Kurbangaliev <i.kurbangaliev@gmail.com>
Cc: Dmitry Dolgov <9erthalion6@gmail.com>
Cc: Andrey Borodin <x4mmm@yandex-team.ru>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: [HACKERS] Custom compression methods (mac+lz4.h)
Date: Mon, 22 Mar 2021 12:04:58 -0400
Message-ID: <574944.1616429098@sss.pgh.pa.us> (raw )
In-Reply-To: <CA+TgmoZhqwvoMQ-6_UcrBXOdvz=66X814VyBWK2jDSN0BPm8Xw@mail.gmail.com >
References: <301730.1616276227@sss.pgh.pa.us >
<20210320231957.GX11765@telsasoft.com >
<309337.1616287493@sss.pgh.pa.us >
<311370.1616290403@sss.pgh.pa.us >
<CAFiTN-tN-fi=9VEatyiZyhW28yhhQCmn-egYzbdxBTLkOnVQvg@mail.gmail.com >
<CAFiTN-t0w+Rc2U3S+y=7KWcLuOYNB5MfWeGdNa7+pg0UovVdcQ@mail.gmail.com >
<414943.1616358751@sss.pgh.pa.us >
<20210321204148.GB4203@telsasoft.com >
<456616.1616360715@sss.pgh.pa.us >
<504396.1616368310@sss.pgh.pa.us >
<20210321234324.GC4203@telsasoft.com >
<507597.1616370729@sss.pgh.pa.us >
<CAFiTN-u1Y2i7TFfC+wZAEiQLHTYMSQafbRisYPqCaU6gQdnPcw@mail.gmail.com >
<558766.1616424108@sss.pgh.pa.us >
<CA+TgmoaG_p5VkYzAGQ0Ndo8PWPOm5Y55UoqBvkqSfoQmG=W1TA@mail.gmail.com >
<574197.1616428079@sss.pgh.pa.us >
<CA+TgmoZhqwvoMQ-6_UcrBXOdvz=66X814VyBWK2jDSN0BPm8Xw@mail.gmail.com >
Robert Haas <robertmhaas@gmail.com> writes:
> On Mon, Mar 22, 2021 at 11:48 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Possibly the former names should survive and the latter become
>> wrappers around them, not sure. But we shouldn't be using the "4B"
>> terminology anyplace except this part of postgres.h.
> I would argue that it shouldn't be used any place at all, and that we
> ought to go the other direction and get rid of the existing macros -
> e.g. change #define VARATT_IS_1B_E to #define VARATT_IS_EXTERNAL
> instead of defining the latter as a no-value-added wrapper around the
> former. Maybe at one time somebody thought that the test for
> VARATT_IS_EXTERNAL might someday have more cases than just
> VARATT_IS_1B_E, but that's not looking like a good bet in 2021.
Maybe. I think the original idea was exactly what the comment says,
to have a layer of macros that'd deal with endianness issues and no more.
That still seems like a reasonable plan to me, though perhaps it wasn't
executed very well.
regards, tom lane
view thread (21+ messages)
Message-ID: <574944.1616429098@sss.pgh.pa.us>
Permalink: ../574944.1616429098@sss.pgh.pa.us/
Also on: postgresql.org/message-id/574944.1616429098@sss.pgh.pa.us
copy link · copy postgr.es
reply Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, robertmhaas@gmail.com, dilipbalaut@gmail.com, pryzby@telsasoft.com, andres@anarazel.de, tomas.vondra@2ndquadrant.com, david@pgmasters.net, i.kurbangaliev@gmail.com, 9erthalion6@gmail.com, x4mmm@yandex-team.ru, pgsql-hackers@lists.postgresql.org
Subject: Re: [HACKERS] Custom compression methods (mac+lz4.h)
In-Reply-To: <574944.1616429098@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox