From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Improving the isolationtester: fewer failures, less delay
Date: Tue, 15 Jun 2021 21:22:51 -0400
Message-ID: <591707.1623806571@sss.pgh.pa.us> (raw)
In-Reply-To: <20210616011820.2ktysyfozfhqdtha@alap3.anarazel.de>
References: <327948.1623725828@sss.pgh.pa.us>
<20210615190342.etwfp4mxmuuztumb@alap3.anarazel.de>
<437333.1623784464@sss.pgh.pa.us>
<501471.1623791340@sss.pgh.pa.us>
<20210616011820.2ktysyfozfhqdtha@alap3.anarazel.de>
Andres Freund <andres@anarazel.de> writes:
> Only halfway related: I wonder if we should remove the automatic
> permutation stuff - it's practically never useful. Probably not worth
> changing...
Where it is useful, it saves a lot of error-prone typing ...
> Minor suggestion: I think the folliwing would be a bit easier to read if
> there first were a list of markers, and then separately the longer
> descriptions. Right now it's a bit hard to see which paragraph
> introduces a new type of marker, and which just adds further commentary.
OK, will do. Will act on your other cosmetic points too, tomorrow or so.
>> + if (step_has_blocker(pstep))
>> + {
>> + if (!(flags & STEP_RETRY))
>> + printf("step %s: %s <waiting ...>\n",
>> + step->name, step->sql);
>> + return true;
>> + }
> Might be a bug in my mental state machine: Will this work correctly for
> PSB_ONCE, where we'll already returned before?
This bit ignores PSB_ONCE. Once we've dropped out of try_complete_step
the first time, PSB_ONCE is done affecting things. (I'm not in love
with that symbol name, if you have a better idea.)
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, pgsql-hackers@lists.postgresql.org
Subject: Re: Improving the isolationtester: fewer failures, less delay
In-Reply-To: <591707.1623806571@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox