From: Grigory Smolkin <g.smolkin@postgrespro.ru>
To: pgsql-hackers@lists.postgresql.org
Subject: Re: readdir is incorrectly implemented at Windows
Date: Wed, 27 Feb 2019 17:00:52 +0300
Message-ID: <591b93df-3d05-c88e-54bd-29c6a94d2a2d@postgrespro.ru> (raw)
In-Reply-To: <2cad7829-8d66-e39c-b937-ac825db5203d@postgrespro.ru>
References: <2cad7829-8d66-e39c-b937-ac825db5203d@postgrespro.ru>
Originally bug was reported by Yuri Kurenkov:
https://github.com/postgrespro/pg_probackup/issues/48
As pg_probackup rely on readdir() for listing files to backup, wrong
permissions could lead to a broken backup.
On 02/25/2019 06:38 PM, Konstantin Knizhnik wrote:
> Hi hackers,
>
> Small issue with readir implementation for Windows.
> Right now it returns ENOENT in case of any error returned by
> FindFirstFile.
> So all places in Postgres where opendir/listdir are used will assume
> that directory is empty and
> do nothing without reporting any error.
> It is not so good if directory is actually not empty but there are not
> enough permissions for accessing the directory and FindFirstFile
> returns ERROR_ACCESS_DENIED:
>
> struct dirent *
> readdir(DIR *d)
> {
> WIN32_FIND_DATA fd;
>
> if (d->handle == INVALID_HANDLE_VALUE)
> {
> d->handle = FindFirstFile(d->dirname, &fd);
> if (d->handle == INVALID_HANDLE_VALUE)
> {
> errno = ENOENT;
> return NULL;
> }
> }
>
>
> Attached please find small patch fixing the problem.
>
--
Grigory Smolkin
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: g.smolkin@postgrespro.ru, pgsql-hackers@lists.postgresql.org
Subject: Re: readdir is incorrectly implemented at Windows
In-Reply-To: <591b93df-3d05-c88e-54bd-29c6a94d2a2d@postgrespro.ru>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox