public inbox for [email protected]  

help / color / mirror / Atom feed

From: Tom Lane <[email protected]>
To: Michael Paquier <[email protected]>
Cc: Ning <[email protected]>
Cc: [email protected]
Cc: Andrew Dunstan <[email protected]>
Subject: Re: psql client does not handle WSAEWOULDBLOCK on Windows
Date: Tue, 02 Sep 2025 11:51:41 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <CAFGqpvg-pRw=cdsUpKYfwY6D3d-m9tw8WMcAEE7HHWfm-oYWvw@mail.gmail.com>
	<CAFGqpvgJ_Y-POTgogbmzxTbUXrci3gLqcasw1rAZ4y2Wh+9+nA@mail.gmail.com>
	<[email protected]>

Michael Paquier <[email protected]> writes:
> This is going to require some platform-specific check that I don't
> have with me, though I am ready to accept that what you are telling
> here is true and that we should apply this macro.  Could somebody
> check that a bit more in depth?  Andrew D. perhaps?

> One thing that I don't understand is why does this only apply after
> the first call of pqsecure_raw_read() in gss_read()?  There is a
> second call of pqsecure_raw_read() you are not covering but it would
> surely need the same treatment, no?

> Also, what about pqsecure_raw_write() in pqsecure_open_gss()?
> Shouldn't the same check apply?

Yeah, I think we pretty much need to use SOCK_ERRNO, SOCK_ERRNO_SET,
and SOCK_STRERROR (if relevant) throughout fe-secure-gssapi.c.
Directly using errno is correct for syscalls related to the file
system, but I think everything in this file is dealing with
socket-related errors.  Certainly the underlying pqsecure_raw_read
and pqsecure_raw_write layer expects those macros to be used.

Like you, I'm not really in a position to test this on Windows ...

			regards, tom lane

view thread (6+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: psql client does not handle WSAEWOULDBLOCK on Windows
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox