pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Petr Jelinek <petr.jelinek@2ndquadrant.com>
To: Andres Freund <andres@anarazel.de>
To: Robert Haas <robertmhaas@gmail.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Cc: Petr Jelinek <petr@2ndquadrant.com>
Cc: Peter Eisentraut <peter_e@gmx.net>
Subject: Re: logical replication launcher crash on buildfarm
Date: Sat, 1 Apr 2017 04:46:39 +0200
Message-ID: <59710cc4-0adf-e21b-cba6-1488c632e5b4@2ndquadrant.com> (raw)
In-Reply-To: <20170401021928.47zjjryhty5kdzqz@alap3.anarazel.de>
References: <e3c35f3a-426d-b1ca-7fe5-9241c2717013@2ndquadrant.com>
	<CA+Tgmoae_obbYapxDhELe852TO1nFGOdVbWiUwa6Gf+ODxjHnQ@mail.gmail.com>
	<0471e978-b121-ad2f-2879-f1694d9a5ce7@2ndquadrant.com>
	<d217ee26-f3d1-4079-0110-3f7ee44ad6b4@2ndquadrant.com>
	<2124fb62-2393-8525-4fe9-b95b1b689d09@2ndquadrant.com>
	<CA+TgmobNi6++NFCQgSay4A05-FNVFfYVKxfBa00zke8vqU1V3Q@mail.gmail.com>
	<09d8ad33-4287-a09b-a77f-77f8761adb5e@2ndquadrant.com>
	<CA+TgmoZktru0SK1b9888gYF=zmX_haRm+6i8rBP0APS6yO8+NA@mail.gmail.com>
	<8ebd3aa3-55eb-1106-7c10-7e7579f94582@2ndquadrant.com>
	<CA+TgmobGk3DEo++oqkFi8AaYXhCs-0DUNMU9HdCh56udXFF=PA@mail.gmail.com>
	<20170401021928.47zjjryhty5kdzqz@alap3.anarazel.de>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>

On 01/04/17 04:19, Andres Freund wrote:
> On 2017-03-31 21:30:17 -0400, Robert Haas wrote:
>> On Fri, Mar 31, 2017 at 9:26 PM, Petr Jelinek
>> <petr.jelinek@2ndquadrant.com> wrote:
>>>> Hmm, I don't know if there's any good reason not to just use strcmp(),
>>>> but sure, OK.  Committed and back-patched.
>>>
>>> Hmm culicidae still fails, this time only in parallel worker code. This
>>> didn't happen on my machine which is strange. Looking at the code, we
>>> are passing the fps->entrypoint as function pointer again so of course
>>> it fails. We have some code to load libraries again but even that gets
>>> initial entrypoint passed as function pointer
>>> (ParallelExtensionTrampoline). I wonder if we'll have to generalize the
>>> InternalBGWorkers even more to some kind of internal function name to
>>> pointer map and add the parallel entry points there as well.
>>
>> Argh, I forgot about that.  I think we need to use something like
>> ParallelExtensionTrampoline all the time, not just for libraries.
>> Since effectively, we've determined that postgres itself has the same
>> problem.
> 
> I wonder if we shouldn't just introduce a KnownFunctionPointer[] map,
> that can be used by various facilities (bgworkers themselves,
> parallelism, and probably more coming).  Otherwise we'll introduce
> mechanisms like 7d8f6986b8 in multiple places.
> 

Yes that's what I meant with what I said above.

-- 
  Petr Jelinek                  http://www.2ndQuadrant.com/
  PostgreSQL Development, 24x7 Support, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



view thread (41+ messages)  latest in thread

Message-ID: <59710cc4-0adf-e21b-cba6-1488c632e5b4@2ndquadrant.com>
Permalink:  ../59710cc4-0adf-e21b-cba6-1488c632e5b4@2ndquadrant.com/
Also on:    postgresql.org/message-id/59710cc4-0adf-e21b-cba6-1488c632e5b4@2ndquadrant.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: petr.jelinek@2ndquadrant.com, andres@anarazel.de, robertmhaas@gmail.com, petr@2ndquadrant.com, peter_e@gmx.net
  Subject: Re: logical replication launcher crash on buildfarm
  In-Reply-To: <59710cc4-0adf-e21b-cba6-1488c632e5b4@2ndquadrant.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox