From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Splitting up guc.c
Date: Sat, 10 Sep 2022 15:35:05 -0400
Message-ID: <599818.1662838505@sss.pgh.pa.us> (raw)
In-Reply-To: <597492.1662837820@sss.pgh.pa.us>
References: <587607.1662836699@sss.pgh.pa.us>
<20220910191533.4d7xib46m62sf2mv@awork3.anarazel.de>
<597492.1662837820@sss.pgh.pa.us>
I wrote:
> Andres Freund <andres@anarazel.de> writes:
>> On 2022-09-10 15:04:59 -0400, Tom Lane wrote:
>>> $ size guc*o
>>> text data bss dec hex filename
>>> 13653 4 112 13769 35c9 guc-file.o
>>> 54953 0 564 55517 d8dd guc.o
>>> 6951 0 112 7063 1b97 guc_hooks.o
>>> 43570 62998 216 106784 1a120 guc_tables.o
>> A tad surprised by the text size of guc_tables.o - not that it is a problem,
>> just seems a bit odd.
> There's a pretty fair number of constant tables that got moved to there.
> Not to mention all the constant strings.
I forgot to include comparison numbers for HEAD:
$ wc guc*c
2629 9372 69467 guc-file.c
13335 41584 356896 guc.c
15964 50956 426363 total
$ size guc*o
text data bss dec hex filename
13653 4 112 13769 35c9 guc-file.o
105848 63156 908 169912 297b8 guc.o
This isn't completely apples-to-apples because of the few
hook functions I'd moved to other places in v1, but you can
see that the total text and data sizes didn't change much.
It'd likely indicate a mistake if they had. (However, v1
does include const-ifying a few options tables that had
somehow escaped being labeled that way, so the total data
size did shrink a small amount.)
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, pgsql-hackers@lists.postgresql.org
Subject: Re: Splitting up guc.c
In-Reply-To: <599818.1662838505@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox