From: Mark Dilger <hornschnorter@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: Missing test of SPI copy functionality
Date: Thu, 7 Nov 2019 06:25:54 -0800
Message-ID: <59befd2c-0159-5c1c-80b4-92ec72f8db19@gmail.com> (raw)
In-Reply-To: <20191107022716.GF1768@paquier.xyz>
References: <a6e9b130-7fd5-387b-4ec5-89bda24373ab@gmail.com>
<20191107022716.GF1768@paquier.xyz>
On 11/6/19 6:27 PM, Michael Paquier wrote:
> On Wed, Nov 06, 2019 at 04:16:14PM -0800, Mark Dilger wrote:
>> While working on cleaning up the SPI interface, I found that one of the SPI
>> error codes, SPI_ERROR_COPY, is never encountered in any test case when
>> running `make check-world`. This case is certainly reachable by a user, as
>> is shown in the attached patch. Is this tested from some other
>> infrastructure?
>
> Hard to say, but I think that it would be good to test that part
> independently anyway. The transaction part close by is actually
> getting stressed with plpgsql_transaction, so the split done in your
> patch looks fine. I'll look at it again in a couple of days to
> double-check for missing spots, and commit it if there are no
> objections.
Thanks for reviewing!
--
Mark Dilger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: hornschnorter@gmail.com, michael@paquier.xyz
Subject: Re: Missing test of SPI copy functionality
In-Reply-To: <59befd2c-0159-5c1c-80b4-92ec72f8db19@gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox